Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CI workflow versions to use latest checkout (removes deprecation warning) #1734

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-conda-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
CUDA_VERSION: ${{ matrix.cuda_version }}
steps:
- name: Checkout PyTorch builder
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Authenticate if WITH_PUSH
run: |
if [[ "${WITH_PUSH}" == true ]]; then
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-libtorch-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ jobs:
runs-on: linux.12xlarge.ephemeral
strategy:
matrix:
cuda_version: ["12.4", "12.1", "11.8"]
cuda_version: ["11.8", "12.1", "12.4"]
env:
GPU_ARCH_TYPE: cuda
GPU_ARCH_VERSION: ${{ matrix.cuda_version }}
steps:
- name: Checkout PyTorch builder
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Authenticate if WITH_PUSH
run: |
if [[ "${WITH_PUSH}" == true ]]; then
Expand All @@ -58,7 +58,7 @@ jobs:
GPU_ARCH_VERSION: ${{ matrix.rocm_version }}
steps:
- name: Checkout PyTorch
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Authenticate if WITH_PUSH
run: |
if [[ "${WITH_PUSH}" == true ]]; then
Expand All @@ -71,7 +71,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout PyTorch
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Authenticate if WITH_PUSH
run: |
if [[ "${WITH_PUSH}" == true ]]; then
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-magma-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ jobs:
runs-on: linux.2xlarge
strategy:
matrix:
cuda_version: ["124", "121", "118"]
cuda_version: ["118", "121", "124"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the benefit of changing the order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None! it was just trying to be consistent with increasing versions left-to-right

steps:
- name: Checkout PyTorch builder
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Build Magma Cuda
working-directory: magma
run: |
Expand All @@ -45,7 +45,7 @@ jobs:
- name: Install conda
uses: conda-incubator/setup-miniconda@v2
with:
python-version: 3.8
python-version: 3.9
auto-update-conda: true
miniconda-version: "latest"
activate-environment: build-linux-magma
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-magma-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Build MAGMA for Windows
on:
push:
branches:
main
- main
paths:
- windows/internal/build_magma.bat
- .github/workflows/build-magma-windows.yml
Expand All @@ -14,17 +14,17 @@ on:

jobs:
build-windows-magma:
runs-on: windows-2019
runs-on: windows-2022
strategy:
matrix:
cuda_version: ["124", "121", "118"]
cuda_version: ["118", "121", "124]
config: ["Release", "Debug"]
env:
CUDA_VERSION: ${{ matrix.cuda_version }}
CONFIG: ${{ matrix.config }}
steps:
- name: Checkout pytorch/builder
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Enable MSVC dev commands to enable cl.exe # FYI incompatible with shell: bash
uses: ilammy/msvc-dev-cmd@dd5e2fa0a7de1e7929605d9ecc020e749d9856a3
- name: Install CUDA Toolkit
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build-manywheel-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ jobs:
runs-on: linux.12xlarge.ephemeral
strategy:
matrix:
cuda_version: ["12.4", "12.1", "11.8"]
cuda_version: ["11.8", "12.1", "12.4"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #1726

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! reverted this change in e5c34ca

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily needed, but I appreciate it.

env:
GPU_ARCH_TYPE: cuda
GPU_ARCH_VERSION: ${{ matrix.cuda_version }}
steps:
- name: Purge tools folder (free space for build)
run: rm -rf /opt/hostedtoolcache
- name: Checkout PyTorch builder
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Authenticate if WITH_PUSH
run: |
if [[ "${WITH_PUSH}" == true ]]; then
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
GPU_ARCH_VERSION: ${{ matrix.rocm_version }}
steps:
- name: Checkout PyTorch
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Authenticate if WITH_PUSH
run: |
if [[ "${WITH_PUSH}" == true ]]; then
Expand All @@ -98,7 +98,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout PyTorch
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Authenticate if WITH_PUSH
run: |
if [[ "${WITH_PUSH}" == true ]]; then
Expand All @@ -113,7 +113,7 @@ jobs:
GPU_ARCH_TYPE: cpu-aarch64
steps:
- name: Checkout PyTorch
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Authenticate if WITH_PUSH
run: |
if [[ "${WITH_PUSH}" == true ]]; then
Expand All @@ -128,7 +128,7 @@ jobs:
GPU_ARCH_TYPE: cpu-cxx11-abi
steps:
- name: Checkout PyTorch
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Authenticate if WITH_PUSH
run: |
if [[ "${WITH_PUSH}" == true ]]; then
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-nvidia-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ env:
IN_CI: 1
IS_GHA: 1
IMAGE_NAME: "ghcr.io/pytorch/nvidia/cuda"
CUDA_VERSION: "11.5.0"
OS: "ubuntu1804"
OS_BASE: "ubuntu18.04"
CUDA_VERSION: "11.8.0"
OS: "ubuntu2204"
OS_BASE: "ubuntu22.04"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

ARCHES: "amd64"

jobs:
build-nvidia-docker:
runs-on: ubuntu-18.04
runs-on: ubuntu-22.04
steps:
- name: Build Nvidia Docker Image
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v4
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: pytorch/test-infra
- name: Install requirements
Expand Down
Loading