-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update CI workflow versions to use latest checkout (removes deprecation warning) #1734
Changes from all commits
955f963
e5c34ca
c55c0b5
1d9231b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,15 +39,15 @@ jobs: | |
runs-on: linux.12xlarge.ephemeral | ||
strategy: | ||
matrix: | ||
cuda_version: ["12.4", "12.1", "11.8"] | ||
cuda_version: ["11.8", "12.1", "12.4"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please see #1726 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thank you! reverted this change in e5c34ca There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not necessarily needed, but I appreciate it. |
||
env: | ||
GPU_ARCH_TYPE: cuda | ||
GPU_ARCH_VERSION: ${{ matrix.cuda_version }} | ||
steps: | ||
- name: Purge tools folder (free space for build) | ||
run: rm -rf /opt/hostedtoolcache | ||
- name: Checkout PyTorch builder | ||
uses: actions/checkout@v3 | ||
uses: actions/checkout@v4 | ||
- name: Authenticate if WITH_PUSH | ||
run: | | ||
if [[ "${WITH_PUSH}" == true ]]; then | ||
|
@@ -85,7 +85,7 @@ jobs: | |
GPU_ARCH_VERSION: ${{ matrix.rocm_version }} | ||
steps: | ||
- name: Checkout PyTorch | ||
uses: actions/checkout@v3 | ||
uses: actions/checkout@v4 | ||
- name: Authenticate if WITH_PUSH | ||
run: | | ||
if [[ "${WITH_PUSH}" == true ]]; then | ||
|
@@ -98,7 +98,7 @@ jobs: | |
runs-on: ubuntu-22.04 | ||
steps: | ||
- name: Checkout PyTorch | ||
uses: actions/checkout@v3 | ||
uses: actions/checkout@v4 | ||
- name: Authenticate if WITH_PUSH | ||
run: | | ||
if [[ "${WITH_PUSH}" == true ]]; then | ||
|
@@ -113,7 +113,7 @@ jobs: | |
GPU_ARCH_TYPE: cpu-aarch64 | ||
steps: | ||
- name: Checkout PyTorch | ||
uses: actions/checkout@v3 | ||
uses: actions/checkout@v4 | ||
- name: Authenticate if WITH_PUSH | ||
run: | | ||
if [[ "${WITH_PUSH}" == true ]]; then | ||
|
@@ -128,7 +128,7 @@ jobs: | |
GPU_ARCH_TYPE: cpu-cxx11-abi | ||
steps: | ||
- name: Checkout PyTorch | ||
uses: actions/checkout@v3 | ||
uses: actions/checkout@v4 | ||
- name: Authenticate if WITH_PUSH | ||
run: | | ||
if [[ "${WITH_PUSH}" == true ]]; then | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,14 +23,14 @@ env: | |
IN_CI: 1 | ||
IS_GHA: 1 | ||
IMAGE_NAME: "ghcr.io/pytorch/nvidia/cuda" | ||
CUDA_VERSION: "11.5.0" | ||
OS: "ubuntu1804" | ||
OS_BASE: "ubuntu18.04" | ||
CUDA_VERSION: "11.8.0" | ||
OS: "ubuntu2204" | ||
OS_BASE: "ubuntu22.04" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point! |
||
ARCHES: "amd64" | ||
|
||
jobs: | ||
build-nvidia-docker: | ||
runs-on: ubuntu-18.04 | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- name: Build Nvidia Docker Image | ||
run: | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the benefit of changing the order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None! it was just trying to be consistent with increasing versions left-to-right