-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To fix #3277 #3280
To fix #3277 #3280
Conversation
To fix pytorch#3277 , replace `_VALID_PARAM_AND_METRIC_NAMES ` to regular expression from `mlflow` https://github.com/mlflow/mlflow/blob/d6625d6df85b61f3661ba90efc36f94511a5c23f/mlflow/utils/validation.py#L15C1-L15C60
Hey @puhuk , thanks for the PR, can you check what mlflow did with |
@vfdev-5 Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @puhuk !
Fixes #3277
Description:
To fix #3277 , replace
_VALID_PARAM_AND_METRIC_NAMES
to regular expression frommlflow
https://github.com/mlflow/mlflow/blob/d6625d6df85b61f3661ba90efc36f94511a5c23f/mlflow/utils/validation.py#L15C1-L15C60
Check list: