Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Algorithm] TD3+BC #2249

Merged
merged 22 commits into from
Jul 9, 2024
Merged

[Algorithm] TD3+BC #2249

merged 22 commits into from
Jul 9, 2024

Conversation

BY571
Copy link
Contributor

@BY571 BY571 commented Jun 26, 2024

Description

Adds the offline RL algorithm TD3+BC as described in the paper A Minimalist Approach to
Offline Reinforcement Learning
.

Performance is verified for half-cheeta medium dataset:
image

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

Copy link

pytorch-bot bot commented Jun 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2249

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit acc9baf with merge base a151923 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2024
@BY571 BY571 marked this pull request as ready for review June 26, 2024 08:34
@vmoens vmoens added the new algo New algorithm request or PR label Jun 26, 2024
sota-implementations/td3+bc/td3+bc.py Outdated Show resolved Hide resolved
sota-implementations/td3+bc/td3+bc.py Outdated Show resolved Hide resolved
sota-implementations/td3+bc/td3+bc.py Outdated Show resolved Hide resolved
sota-implementations/td3+bc/td3+bc.py Outdated Show resolved Hide resolved
sota-implementations/td3+bc/utils.py Outdated Show resolved Hide resolved
torchrl/objectives/td3_bc.py Outdated Show resolved Hide resolved
torchrl/objectives/td3_bc.py Outdated Show resolved Hide resolved
torchrl/objectives/td3_bc.py Outdated Show resolved Hide resolved
torchrl/objectives/td3_bc.py Show resolved Hide resolved
torchrl/objectives/td3_bc.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need a few more doctrings. I added some in CrossQ, feel free to take them as example

torchrl/objectives/td3_bc.py Outdated Show resolved Hide resolved
torchrl/objectives/td3_bc.py Show resolved Hide resolved
torchrl/objectives/td3_bc.py Outdated Show resolved Hide resolved
torchrl/objectives/td3_bc.py Show resolved Hide resolved
test/test_cost.py Outdated Show resolved Hide resolved
@BY571
Copy link
Contributor Author

BY571 commented Jul 9, 2024

Docstrings are updated :)

@vmoens vmoens merged commit 3566388 into pytorch:main Jul 9, 2024
59 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. new algo New algorithm request or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants