Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add Custom Options for VideoRecorder #2259

Merged
merged 8 commits into from
Jul 4, 2024

Conversation

N00bcak
Copy link
Contributor

@N00bcak N00bcak commented Jul 1, 2024

Description

  • Add the ability to specify FFmpeg kwargs for torchrl.record.VideoRecorder
  • Added notes to knowledge base on how to find FFmpeg kwargs and apply them to VideoRecorders
  • Made said notes accessible by linking knowledge base on the "Get started with logging" page

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

close #2258

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • New feature (non-breaking change which adds core functionality)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

Copy link

pytorch-bot bot commented Jul 1, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2259

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 48d8855 with merge base ba6897d (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2024
@vmoens vmoens changed the title Add Custom Options for VideoRecorder [Doc] Add Custom Options for VideoRecorder Jul 2, 2024
@vmoens
Copy link
Contributor

vmoens commented Jul 2, 2024

@N00bcak I made a couple of edits, can you give it a look?

@vmoens vmoens added the documentation Improvements or additions to documentation label Jul 2, 2024
@N00bcak
Copy link
Contributor Author

N00bcak commented Jul 2, 2024

yep, looks good to me!

@vmoens
Copy link
Contributor

vmoens commented Jul 2, 2024

@N00bcak if you look at the examples CI we still have an issue with duplicated args, can you have a look at that?

@vmoens vmoens merged commit 55f0a52 into pytorch:main Jul 4, 2024
52 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants