Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load all models including targz #3329

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

m10an
Copy link
Contributor

@m10an m10an commented Sep 22, 2024

Description

Fixes #3320

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

ran torchserve_sanity.py and regression_tests.py

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

I haven't found any tests related testing load_models=all parameter in order to add case for tar.gz. Maybe I missed, or maybe it worth to create one, but not sure which place is most appropriate for this type of test (frontend test, pytest?).

@m10an
Copy link
Contributor Author

m10an commented Sep 22, 2024

regression_logs.txt

@mreso mreso self-requested a review September 23, 2024 17:06
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@mreso mreso added this pull request to the merge queue Sep 23, 2024
Merged via the queue into pytorch:master with commit 6881ec5 Sep 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow .tar.gz models to be loaded using load_models=all
2 participants