Improve graph generation with ROI #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- anchors are called like their parent state (_anchor-prefix) was removed - improve support for parallel states
- deleting tox.ini
- add noxfile - update MANIFEST
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #634 +/- ##
==========================================
+ Coverage 98.31% 98.40% +0.08%
==========================================
Files 13 13
Lines 2557 2573 +16
==========================================
+ Hits 2514 2532 +18
+ Misses 43 41 -2
☔ View full report in Codecov by Sentry. |
- adjust noxfile
- removed some unused code
- maintain unions for active state
- also install diagrams for mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the handling of diagrams when working with parallel states, especially when using the
show_roioption (see #627).Furthermore, local testing switched from tox to nox since tox stopped working for me (MacOS, pyenv, venv).
There have been changes to how nodes are named. "Anchor" nodes (black, sometimes invisible 'points' required as an initial node for cluster) do not have "_anchor" suffixes any longer. This eases the resolution of relevant edges when filtering ROI graphs.