Catch BaseException instead of Exception
#641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleneum
changed the title
BaseException instead of Exception
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #641 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 13 13
Lines 2573 2573
=======================================
Hits 2532 2532
Misses 41 41
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptionis not broad enough and does not catchasyncio.CancelledErrororKeyboardInterrupt.transitionswill exclusively catchBaseExceptionfrom now on.This has to major implications: First
on_exceptionis not called when a task is cancelled. This will happen when an asynchronous event cancels currently running callbacks or a KeyboardInterrupt is called. Second, whenqueue=TrueCancelledErrorwill not cause the queue to get cleared and render the machine unusable from thereon.