Update MODIS L1b reader with additional geoinfo datasets #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
approved these changes
Oct 22, 2024
satpy/readers/hdfeos_base.py
Outdated
Comment on lines
336
to
339
| "water_present": "WaterPresent", | ||
| "land_sea_mask": "Land/SeaMask", | ||
| "height": "Height", | ||
| "range": "Range", |
There was a problem hiding this comment.
I'm tempted to say these should be assigned via the file_key in the YAML definition, but then again the way you've done this isn't disallowed... 🤷♂️
There was a problem hiding this comment.
I'm just copying the format of what was already there, tbh!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2946 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 377 377
Lines 55134 55134
=======================================
Hits 52976 52976
Misses 2158 2158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11681775231Details
💛 - Coveralls |
mraspaud
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MODIS L1b reader misses a few useful datasets from the MOD03 files. This PR adds the most commonly used of those datasets:
land_water_mask,height,range,water_present.