Dependency/Project updates #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing setup code directly in `create_app` as per the docs.
|
Thank you @derkweijers! I approved the workflow but will let @encukou do the merging (I cannot fix problems with the deployment if they happen). |
We use the library for years before 2016. See: honzajavorek/czech-holidays#15
|
Thanks for the PR, and sorry for the delay! I'd like to keep the old version of czech_holidays, since we do use years before 2016. It seems rosti uses Python 3.8, so I'll add that. And, note that the CVEs dependabot opened don't really apply here :) |
Turns out that was outdated info! The live site is now on Python 3.11 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ahoj,
While still in the spirits of EuroPython 2023, I was checking out the Pyvo website/code and noticed some old dependencies and CVEs.
This PR updates the dependencies and fixes the
czech_holidaypackage since it's functions have changed a bit. Thebefore_first_requestdecorator is removed in Flask 2.3, this code is moved to thecreate_appfunction itself.All tests (tested on Python 3.9, 3.10 & 3.11) are working. Please note that
czech_holidaycan't be used for dates before 2016, so these are excluded from the spider.The classifiers/packages in
setup.pyare updated. It's been a while since I've worked with this module, so please let me know if I've missed something.Finally, the GitHub action is updated to run the tests with Python 3.9, 3.10 and 3.11.