-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description of how to navigate RGBA images to the kikuchipy documentation #653
Conversation
Signed-off-by: AndreasBugten <andreas.v.bugten@ntnu.no>
Thanks for this suggestion, @AndreasBugten. Can you remove the test.txt file and add the suggestion to the appropriate part of the relevant tutorial: https://github.com/pyxem/kikuchipy/blob/develop/doc/tutorials/visualizing_patterns.ipynb? |
Signed-off-by: AndreasBugten <andreas.v.bugten@ntnu.no>
… into kikuchidev
Signed-off-by: AndreasBugten <andreas.v.bugten@ntnu.no>
Signed-off-by: AndreasBugten <andreas.v.bugten@ntnu.no>
Signed-off-by: AndreasBugten <andreas.v.bugten@ntnu.no>
Signed-off-by: AndreasBugten <andreas.v.bugten@ntnu.no>
The change looks good, @AndreasBugten! https://kikuchipy--653.org.readthedocs.build/en/653/tutorials/visualizing_patterns.html#Any-image To clarify that the two new maps come from two different plotting commands, I'll split the cells into two after I'll also add you as a contributor. Is it OK if I add NTNU as your affiliation and your ORCID, like this? Lines 4 to 6 in 3e0c8c0
|
That is ok, @hakonanes! Thank you very much. |
Andreas V. Bugten or just Andreas Bugten? |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Andreas V. Bugten is good. Thank you. |
Thank you for your first contribution to kikuchipy, @AndreasBugten! I'm hoping for more... |
Description of the change
In the kikuchipy documentation it is not described how one can navigate in RGBA images. The description can be added to the "Any image" part in the tutorial "Visualizing patterns" (https://kikuchipy.org/en/stable/tutorials/visualizing_patterns.html#Any-image).
Progress of the PR
For reviewers
__init__.py
.section in
CHANGELOG.rst
.release.py
,.zenodo.json
and.all-contributorsrc
with the table regenerated.