Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richdata entity card support #1905

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

HamzaAnis
Copy link

PR Details

Added support for Data Entity Types which supports richer data structures within Excel

image

Description

Related Issue

#1853

Motivation and Context

Able to add Entity card from excelize.

How Has This Been Tested

Wrote unit tests and did manual testing.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 24, 2024
@xuri
Copy link
Member

xuri commented May 24, 2024

Thanks for your PR. This PR has a lot of code, I need some time to review.

@xuri xuri force-pushed the master branch 2 times, most recently from 79958aa to 0c3dfb1 Compare May 25, 2024 17:26
@HamzaAnis
Copy link
Author

Let me know if you will have any questions.

@jankrynauw
Copy link

Hi Xuri, when do you think you will be able to look at this PR?

@xuri
Copy link
Member

xuri commented Sep 24, 2024

Sorry for the late reply. I've been busy recently. I may review this PR next month.

@jspanjaardx
Copy link

Hi Xuri, do you have an estimate of when you'll be able to look at the PR? We would love to start integrating this.

@xuri
Copy link
Member

xuri commented Oct 25, 2024

Sorry, I have been really busy recently, so I am afraid I can't give an exact date to review this large PR. I will take this as a high priority in my free time. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants