added support for inter-cluster tls and changing the inter-cluster port numbers #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also fixes #216 |
|
Encountered this problem as well. Using your fix now until your PR is merged, thanks! |
|
I will try and work out why the commands are timing out in the integration test |
|
its really strange, individually the test files work but together they are failing |
|
Maybe something is not correctly cleaned up. I can have a look, but earliest next week. |
|
Here is a result log with all debugging enabled |
|
hey @bashofmann have you been able to take a look at why the test may be failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new helper variables for the p2p protocol and port.
These are then used when templating
initialize.shin/charts/qdrant/templates/configmap.yamlFixes #222
Any advice or feedback would be very appreciated as I'm new to open source contributing. :)