Address review

qgis · Jul 9, 2024 · 3dd90b7 · 3dd90b7
1 parent 6d8ba6e
commit 3dd90b7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/core/browser/qgsfilebaseddataitemprovider.cpp b/src/core/browser/qgsfilebaseddataitemprovider.cpp
@@ -251,7 +251,7 @@ QVector<QgsDataItem *> QgsFileDataCollectionItem::createChildren()
           {
             uriParts.insert( it.key(), it.value() );
           }
-          QString updatedUri = metadata->encodeUri( uriParts );
+          const QString updatedUri = metadata->encodeUri( uriParts );
 
           sublayers.append( metadata->querySublayers( updatedUri.isEmpty() ? path() : updatedUri, Qgis::SublayerQueryFlag::ResolveGeometryType ) );
         }

diff --git a/src/core/providers/gdal/qgsgdalclouddataitems.cpp b/src/core/providers/gdal/qgsgdalclouddataitems.cpp
@@ -49,7 +49,7 @@ QVector<QgsDataItem *> QgsGdalCloudRootItem::createChildren()
   {
     // only expose items for drivers with stored connections
     bool foundConnection = false;
-    for ( const QString &connName : connectionList )
+    for ( const QString &connName : std::as_const( connectionList ) )
     {
       const QgsGdalCloudProviderConnection::Data connectionData = QgsGdalCloudProviderConnection::connection( connName );
       if ( connectionData.vsiHandler == handler.identifier )
@@ -178,7 +178,7 @@ QVector<QgsDataItem *> QgsGdalCloudDirectoryItem::createChildren()
     extraUriParts.insert( QStringLiteral( "credentialOptions" ), connectionData.credentialOptions );
   }
 
-  for ( const QgsGdalCloudProviderConnection::DirectoryObject &object : objects )
+  for ( const QgsGdalCloudProviderConnection::DirectoryObject &object : std::as_const( objects ) )
   {
     const QString subPath = mDirectory + '/' + object.name;
     if ( object.isDir )