Fix some places we should be using const ref for arguments

(cherry picked from commit 4fe4a9e)
qgis · Dec 16, 2024 · 5206ee9 · 5206ee9
1 parent d2cf63c
commit 5206ee9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/python/PyQt6/core/auto_generated/pointcloud/qgspointcloudstatistics.sip.in b/python/PyQt6/core/auto_generated/pointcloud/qgspointcloudstatistics.sip.in
@@ -96,7 +96,7 @@ Merges the current statistics with the statistics from ``stats``
 Converts the current statistics object into JSON object
 %End
 
-    static QgsPointCloudStatistics fromStatisticsJson( QByteArray stats );
+    static QgsPointCloudStatistics fromStatisticsJson( const QByteArray &stats );
 %Docstring
 Creates a statistics object from the JSON object ``stats``
 %End

diff --git a/python/core/auto_generated/pointcloud/qgspointcloudstatistics.sip.in b/python/core/auto_generated/pointcloud/qgspointcloudstatistics.sip.in
@@ -96,7 +96,7 @@ Merges the current statistics with the statistics from ``stats``
 Converts the current statistics object into JSON object
 %End
 
-    static QgsPointCloudStatistics fromStatisticsJson( QByteArray stats );
+    static QgsPointCloudStatistics fromStatisticsJson( const QByteArray &stats );
 %Docstring
 Creates a statistics object from the JSON object ``stats``
 %End

diff --git a/src/core/pointcloud/qgspointcloudstatistics.cpp b/src/core/pointcloud/qgspointcloudstatistics.cpp
@@ -160,7 +160,7 @@ QByteArray QgsPointCloudStatistics::toStatisticsJson() const
   return statsDoc.toJson( QJsonDocument::Compact );
 }
 
-QgsPointCloudStatistics QgsPointCloudStatistics::fromStatisticsJson( QByteArray statsByteArray )
+QgsPointCloudStatistics QgsPointCloudStatistics::fromStatisticsJson( const QByteArray &statsByteArray )
 {
   QJsonParseError error;
   QJsonDocument document = QJsonDocument::fromJson( statsByteArray, &error );

diff --git a/src/core/pointcloud/qgspointcloudstatistics.h b/src/core/pointcloud/qgspointcloudstatistics.h
@@ -123,7 +123,7 @@ class CORE_EXPORT QgsPointCloudStatistics
     QByteArray toStatisticsJson() const;
 
     //! Creates a statistics object from the JSON object \a stats
-    static QgsPointCloudStatistics fromStatisticsJson( QByteArray stats );
+    static QgsPointCloudStatistics fromStatisticsJson( const QByteArray &stats );
 
 #ifndef SIP_RUN
     //! Returns a map object containing all the statistics