Fix some places we should be using const ref for arguments

qgis · Dec 15, 2024 · c343317 · c343317
1 parent 551c2c3
commit c343317
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 7 deletions.
diff --git a/src/core/labeling/qgslabelingengine.cpp b/src/core/labeling/qgslabelingengine.cpp
@@ -720,7 +720,7 @@ void QgsLabelingEngine::drawLabelCandidateRect( pal::LabelPosition *lp, QgsRende
     drawLabelCandidateRect( lp->nextPart(), context, xform, candidates );
 }
 
-void QgsLabelingEngine::drawLabelMetrics( pal::LabelPosition *label, QgsMapToPixel xform, QgsRenderContext &context, const QPointF &renderPoint )
+void QgsLabelingEngine::drawLabelMetrics( pal::LabelPosition *label, const QgsMapToPixel &xform, QgsRenderContext &context, const QPointF &renderPoint )
 {
   QPainter *painter = context.painter();
   if ( !painter )

diff --git a/src/core/labeling/qgslabelingengine.h b/src/core/labeling/qgslabelingengine.h
@@ -439,7 +439,7 @@ class CORE_EXPORT QgsLabelingEngine
      *
      * \see drawLabelCandidateRect()
      */
-    static void drawLabelMetrics( pal::LabelPosition *label, QgsMapToPixel xform, QgsRenderContext &context, const QPointF &renderPoint );
+    static void drawLabelMetrics( pal::LabelPosition *label, const QgsMapToPixel &xform, QgsRenderContext &context, const QPointF &renderPoint );
 
   protected:
     void processProvider( QgsAbstractLabelProvider *provider, QgsRenderContext &context, pal::Pal &p );

diff --git a/src/core/pointcloud/qgscopcpointcloudindex.cpp b/src/core/pointcloud/qgscopcpointcloudindex.cpp
@@ -307,7 +307,7 @@ QgsPointCloudStatistics QgsCopcPointCloudIndex::metadataStatistics() const
 {
   if ( ! mStatistics )
   {
-    QByteArray statisticsEvlrData = fetchCopcStatisticsEvlrData();
+    const QByteArray statisticsEvlrData = fetchCopcStatisticsEvlrData();
     if ( statisticsEvlrData.isEmpty() )
       mStatistics = QgsPointCloudIndex::metadataStatistics();
     else

diff --git a/src/core/pointcloud/qgspointcloudindex.h b/src/core/pointcloud/qgspointcloudindex.h
@@ -162,9 +162,16 @@ class CORE_EXPORT QgsPointCloudNode
      * Constructs new node object. Should only be called by QgsPointCloudIndex::getNode().
      * Bounds should always be computed by QgsPointCloudNode::bounds().
      */
-    QgsPointCloudNode( QgsPointCloudNodeId id, qint64 pointCount,
-                       QList<QgsPointCloudNodeId> childIds, float error, QgsBox3D bounds )
-      : mId( id ), mPointCount( pointCount ), mChildIds( childIds ), mError( error ), mBounds( bounds )
+    QgsPointCloudNode( const QgsPointCloudNodeId &id,
+                       qint64 pointCount,
+                       const QList<QgsPointCloudNodeId> &childIds,
+                       float error,
+                       const QgsBox3D &bounds )
+      : mId( id )
+      , mPointCount( pointCount )
+      , mChildIds( childIds )
+      , mError( error )
+      , mBounds( bounds )
     {
     }
     //! Returns node's ID (unique in index)

diff --git a/src/core/pointcloud/qgspointcloudstatistics.cpp b/src/core/pointcloud/qgspointcloudstatistics.cpp
@@ -165,7 +165,7 @@ QByteArray QgsPointCloudStatistics::toStatisticsJson() const
   return statsDoc.toJson( QJsonDocument::Compact );
 }
 
-QgsPointCloudStatistics QgsPointCloudStatistics::fromStatisticsJson( QByteArray statsByteArray )
+QgsPointCloudStatistics QgsPointCloudStatistics::fromStatisticsJson( const QByteArray &statsByteArray )
 {
   QJsonParseError error;
   QJsonDocument document = QJsonDocument::fromJson( statsByteArray, &error );