Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GRASS provider ignores default output vector format setting in Processing #58102

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Fix GRASS provider ignores default output vector format setting in Processing #58102

merged 4 commits into from
Jul 15, 2024

Conversation

nyalldawson
Copy link
Collaborator

Fixes #43988

@nyalldawson
[grass] Drop custom defaultVectorFileExtension implementation
d76d0f9 
This fixes the GRASS provider ignoring the "default output
vector layer extension" setting for processing. The override
in the grass provider is NOT required as the base class method
already applies the logic for falling back to shp when gpkg
is not available (which was added here in 2e92dab), and
also correctly respects the default format setting.

Fixes qgis#43988
@nyalldawson
Fix comment grammar
d948634
@nyalldawson nyalldawson added GRASS Processing Relating to QGIS Processing framework or individual Processing algorithms backport queued_ltr_backports Queued Backports backport release-3_38 labels Jul 14, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Jul 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 2261913)

@nyalldawson @lbartoletti
Update python/plugins/grassprovider/grass_provider.py
af631ba 
Co-authored-by: Loïc Bartoletti <lbartoletti@users.noreply.github.com>
@agiudiceandrea agiudiceandrea mentioned this pull request Jul 15, 2024
Closed
@nyalldawson @alexbruy
Update python/plugins/grassprovider/grass_provider.py
2261913 
Co-authored-by: Alexander Bruy <alexander.bruy@gmail.com>
@nyalldawson nyalldawson merged commit a42fdd8 into qgis:master Jul 15, 2024
29 checks passed
@nyalldawson nyalldawson deleted the fix_43988 branch July 15, 2024 18:08
This was referenced Jul 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbruy alexbruy alexbruy left review comments

@lbartoletti lbartoletti lbartoletti approved these changes

Assignees
No one assigned
Labels
backport queued_ltr_backports Queued Backports GRASS Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Milestone
3.40.0
Development

Successfully merging this pull request may close these issues.

[Processing] "Default output vector layer extension" option is not respected by GRASS algorithms
3 participants
@nyalldawson @alexbruy @lbartoletti