Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Update plugins #59275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Oct 30, 2024

Description

Update plugins to reduce vulnerabilities

@github-actions github-actions bot added this to the 3.42.0 milestone Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 1e42135)

@m-kuhn
Copy link
Member

m-kuhn commented Oct 31, 2024

@tygyh could you please disable this automation?

@tygyh
Copy link
Contributor Author

tygyh commented Oct 31, 2024

@tygyh could you please disable this automation?

The commits are the only part which is automated. I assemble it into a PR manually.
Why do you not want me to update the plugins?

@m-kuhn
Copy link
Member

m-kuhn commented Oct 31, 2024

We've had commits like this from a bot (on behalf of a real account) in the past and would like to have control over automations affecting the maintenance effort on this repository.

If you do this manually, no objections.

@elpaso you introduced the JS parts IIRC, what do you think?

@tygyh tygyh force-pushed the snyk-fix-fba207964f9a200e32c7914b6c627671 branch from 66196c0 to 227e0ba Compare November 8, 2024 12:26
requirements.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@m-kuhn
Copy link
Member

m-kuhn commented Nov 8, 2024

Lgtm if you can make the tests pass again

@tygyh tygyh force-pushed the snyk-fix-fba207964f9a200e32c7914b6c627671 branch 3 times, most recently from 2222feb to a5d119d Compare November 21, 2024 07:07
@tygyh
Copy link
Contributor Author

tygyh commented Nov 21, 2024

Lgtm if you can make the tests pass again

I don't know why it's failing. I've tried resetting the branch to earlier commits to see when it broke, but even the first commit breaks the tests.

@tygyh tygyh force-pushed the snyk-fix-fba207964f9a200e32c7914b6c627671 branch 2 times, most recently from 1200ed1 to a3bba59 Compare November 26, 2024 11:54
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 11, 2024
@tygyh tygyh force-pushed the snyk-fix-fba207964f9a200e32c7914b6c627671 branch from a3bba59 to 70dd565 Compare December 14, 2024 11:44
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 14, 2024
@tygyh tygyh force-pushed the snyk-fix-fba207964f9a200e32c7914b6c627671 branch 3 times, most recently from 01415ce to f58851e Compare December 17, 2024 07:17
@nyalldawson
Copy link
Collaborator

@tygyh It's not as straightforward as just bumping the dependancies here -- I gather the actual landing page code will need to be updated for the vue 2->3 transition.

@tygyh
Copy link
Contributor Author

tygyh commented Dec 17, 2024

the actual landing page code will need to be updated for the vue 2->3 transition.

I'll look into how hard that would be. If I get it working I'll update the PR to reflect the changes in scope

@tygyh tygyh force-pushed the snyk-fix-fba207964f9a200e32c7914b6c627671 branch from f58851e to 1e42135 Compare December 17, 2024 17:19
Copy link

github-actions bot commented Jan 1, 2025

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 1, 2025
@tygyh
Copy link
Contributor Author

tygyh commented Jan 6, 2025

I'll bump this for two more weeks since I'm still working on this.

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants