Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call build_artifact_comment.yml only for PRs #59549

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Call build_artifact_comment.yml only for PRs #59549

merged 1 commit into from
Nov 21, 2024

Conversation

3nids
Copy link
Member

@3nids 3nids commented Nov 21, 2024

This will avoid false negative workflow failures

@3nids 3nids requested a review from m-kuhn November 21, 2024 13:59
@github-actions github-actions bot added this to the 3.42.0 milestone Nov 21, 2024
Copy link
Member

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed in external repo, according to @3nids

@3nids 3nids merged commit a5b4ab0 into master Nov 21, 2024
27 checks passed
@3nids 3nids deleted the 3nids-patch-2 branch November 21, 2024 14:06
Copy link

github-actions bot commented Nov 21, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit c04271f)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit c04271f)

@nyalldawson
Copy link
Collaborator

This actually breaks the workflow -- see #59555 .

@3nids
Copy link
Member Author

3nids commented Nov 22, 2024

This workflow would have fail before because there is no zip available since it's on the 3.34 release branch which has no win Qt6 builds.
We can fine tune more by blacklisting some branches.

@nyalldawson
Copy link
Collaborator

@3nids it's missing the test failure report, that's what I'm wanting

@3nids
Copy link
Member Author

3nids commented Nov 22, 2024

@nyalldawson the test failure is brought by the other workflow (https://github.com/qgis/QGIS/blob/master/.github/workflows/write_failure_comment.yml) which I didn't touch and I don't think they depend on each other. Or am I missing something?
Anyway, we can revert if you think that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants