Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: upgrade to Fedora 41 #59595

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

ci: upgrade to Fedora 41 #59595

wants to merge 2 commits into from
+8 −3

Conversation

t0b3
Copy link
Contributor

@t0b3 t0b3 commented Nov 26, 2024

ci: upgrade to Fedora 41

@github-actions github-actions bot added this to the 3.42.0 milestone Nov 26, 2024
@t0b3 t0b3 marked this pull request as draft November 26, 2024 06:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit dfc9bf6)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit dfc9bf6)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Tests failed for Qt 6

One or more tests failed using the build from commit dfc9bf6

composerlabel_renderhtml (renderAsHtml)

composerlabel_renderhtml

Test failed at renderAsHtml at tests/src/core/testqgslayoutlabel.cpp:312

Rendered image did not match tests/testdata/control_images/composer_label/expected_composerlabel_renderhtml/expected_composerlabel_renderhtml.png (found 6342 pixels different)

composerlabel_renderhtmllineheight (renderAsHtmlLineHeight)

composerlabel_renderhtmllineheight

Test failed at renderAsHtmlLineHeight at tests/src/core/testqgslayoutlabel.cpp:340

Rendered image did not match tests/testdata/control_images/composer_label/expected_composerlabel_renderhtmllineheight/expected_composerlabel_renderhtmllineheight.png (found 28075 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

@t0b3
Copy link
Contributor Author

t0b3 commented Nov 26, 2024

this PR uncovers 13 tests failing on Fedora 41 https://cdash.orfeo-toolbox.org/index.php?project=QGIS&filtercount=1&showfilters=1&field1=buildname/string&compare1=63&value1=PR59595_364f314658c5cf9ef69b209cb5463ad275c88086_ALL_BUT_PROVIDERS&date=2024-11-26

@nyalldawson
Copy link
Collaborator

nyalldawson commented Nov 26, 2024 •
edited
Loading

@t0b3
I've previously looked into this. There's regressions in qt library itself relating to svg rendering, and completely broken 3d views on newer qt6 releases (see #57640)

Until these upstream issues are fixed in qt we're stuck with the older release...

@nyalldawson
Copy link
Collaborator

@t0b3

#59619 fixes two of the failing tests, #59620 fixes another two

@troopa81 Can you take a look at the failing project style settings test here? That's relating to the CMYK work.

@t0b3
Copy link
Contributor Author

t0b3 commented Dec 3, 2024

@nyalldawson good progress 😃 5 tests have been fixed
it's only 8 tests with errors left https://cdash.orfeo-toolbox.org/viewTest.php?onlyfailed&buildid=27484

@troopa81
Copy link
Contributor

troopa81 commented Dec 4, 2024

@troopa81 Can you take a look at the failing project style settings test here? That's relating to the CMYK work.

Yes, I'll take a look

@troopa81 troopa81 mentioned this pull request Dec 4, 2024
Merged
@t0b3 t0b3 force-pushed the fc41 branch 2 times, most recently from 360dd0d to 911d47e Compare December 9, 2024 18:18
@t0b3
Copy link
Contributor Author

t0b3 commented Dec 9, 2024

@troopa81 there is still some CMYK assert failing
see https://cdash.orfeo-toolbox.org/test/15990846

@t0b3 t0b3 force-pushed the fc41 branch 10 times, most recently from cc0a71d to 9cece4f Compare December 18, 2024 07:05
@nyalldawson nyalldawson mentioned this pull request Dec 18, 2024
Merged
@troopa81
Copy link
Contributor

Since #59834 , We got the current failure comment

/Deprecated/ supports message argument only for ABI v13.9 and later, or v12.16 or later

I opened an issue in PyQt-builder Python-PyQt/PyQt-builder#25

I could maybe check the abi version in cmake but it requires even more cmake code, and is I think overkill without the issue. I'd rather wait (for now) for it to be fixed upstream.

@t0b3
Copy link
Contributor Author

t0b3 commented Dec 20, 2024

temporary measure:

@nyalldawson
Copy link
Collaborator

@t0b3 maybe you could pin sip at the older version in dnf?

@troopa81
Copy link
Contributor

@t0b3 maybe you could pin sip at the older version in dnf?

The issue has been fixed upstream Python-PyQt/PyQt-builder#25

But I'm gonna add the abi minimum version in our SIP project so it doesn't fail.

@t0b3
Copy link
Contributor Author

t0b3 commented Dec 20, 2024

@t0b3 maybe you could pin sip at the older version in dnf?

The issue has been fixed upstream Python-PyQt/PyQt-builder#25

But I'm gonna add the abi minimum version in our SIP project so it doesn't fail.

perfect, so I return to the previous state 👍

@t0b3 t0b3 force-pushed the fc41 branch 2 times, most recently from 5b18007 to 93f3fbf Compare December 23, 2024 11:08
@t0b3
Copy link
Contributor Author

t0b3 commented Dec 23, 2024 •
edited
Loading

notice to myself sip6-6.8.6-2.fc41.noarch helps to get the build running
with theese 5 tests failing - https://tinyurl.com/2cgtwxvk
93 - test_core_layoutlabel (Failed)
256 - test_gui_dockwidget (Failed)
287 - test_gui_ogrprovidergui (Failed)
417 - PyQgsAnnotationPictureItem (Failed)
699 - PyQgsSvgCache (Failed)

t0b3 added 2 commits December 24, 2024 08:45
@t0b3
ci: upgrade to Fedora 41
2d1a5ba
@t0b3
ci: omit compiler warning on deprecated declarations
dfc9bf6 
clang v18 warns about ...
src/core/painting/qgsmaskpaintdevice.h:36:5: note: 'QgsMaskPaintEngine' has been explicitly marked deprecated here
Q_DECL_DEPRECATED QgsMaskPaintEngine( bool usePathStroker = false );
... while still being used in
src/core/painting/qgsmaskpaintdevice.cpp:65:23: note: in instantiation of function template specialization 'std::make_unique<QgsMaskPaintEngine, bool &>' requested here
mPaintEngine = std::make_unique<QgsMaskPaintEngine>( usePathStroker );
@t0b3 t0b3 force-pushed the fc41 branch 7 times, most recently from 2b7b620 to dfc9bf6 Compare December 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troopa81 troopa81 troopa81 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.42.0
Development

Successfully merging this pull request may close these issues.
3 participants
@t0b3 @nyalldawson @troopa81