Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qt 6 support to CMake project (follow the elgatosf/opensphere approach) #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Nov 24, 2024

This reduces the diff from the elgatosf/opensphere fork.

This changes the following things

  • increases required minimum cmake to 3.16
  • modernizes cmake to set target scoped configurations
  • removes Qt4 compatibility in cmake as it not mentioned in the readme anymore
  • replaces QtKeychain find_packages with a FetchContent directly from github

This changes the following things

- increases required minimum cmake to 3.16
- modernizes cmake to set target scoped configurations
- removes Qt4 compatibility in cmake as it not mentioned in the readme anymore
- replaces QtKeychain find_packages with a FetchContent directly from github
@m-kuhn m-kuhn changed the title Add Qt 6 support to CMake project (follow the opensphere approach) Add Qt 6 support to CMake project (follow the elgatosf/opensphere approach) Nov 24, 2024
@m-kuhn
Copy link
Member Author

m-kuhn commented Nov 24, 2024

Hmm... more vendoring going on ...

replaces QtKeychain find_packages with a FetchContent directly from github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants