Handled overloaded methods correctly #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of contents The overload documenter doesn't play nice here
|
@3nids do you know what broke the class map here? |
3nids
reviewed
Sep 10, 2024
conf.in.py
Outdated
| qgis_module_path = candidate_path | ||
| break | ||
|
|
||
| if qgis_module_path: |
There was a problem hiding this comment.
this will be silently skipped, should we at least raise a warning?
I'm a bit concerned that for whatever reason, there is no more class_map file from QGIS and the docs are built without error.
There was a problem hiding this comment.
Ok, I've reverted that bit, but have revised the class map download to use a user-writable location instead.
3nids
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this now: