-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release - v1.3.1 #201
Release - v1.3.1 #201
Conversation
Improve bug report template
Fix typo in the template
TS fix: `secondFactorCode` type was missing in Storage constructor (TS)
I guess we can wait to #205 to be fixed before releasing v1.3.1, right? About the error in the Deno test integration, it was not an error in the library itself but in Deno somehow: Snippet of the error log
|
Fantastic troubleshooting in the aforementioned Issue. In the meantime I'll make another PR soon with some more missing TS types. I found a few more so I'll lump them into manageable PRs rather than one-liners. Hopefully that will be in time for the new release, as well 😄. |
That's fine, I'm really grateful you are helping in this project! 😄 |
TS fix: find,filter,navigate in `storage`
I need to fix the Deno tests: from the error log that's just something wrong in the arguments to "deno test" in the test runner which includes a forward slash with the port number. |
--allow-net should not include a trailing slash
Fix Deno tests
I always forget about that, so is better to put it in the readme.
Add a note about updating TypeScript types
It was calling .find instead of calling .filter to recurse directories
Fix .filter implementation
Handle `ssl` in API's pull request so Storage works in browsers
Use globalThis.isSecureContext
Simplify handleForceHttps
Release v1.3.1
ssl
in API's pull request so Storage works in browsers #209storage
#206secondFactorCode
type was missing in Storage constructor (TS) #204Changelog
Patch Changes
Simplify handleForceHttps (@qgustavor)
Use
globalThis.isSecureContext
. Advantages and disadvantages shown in detail here.Handle
ssl
in API's pull request so Storage works in browsers (@qgustavor)Should fix issue #205 where the Storage class does not work on HTTPS websites.
Fix .filter implementation (@qgustavor)
It was calling .find instead of calling .filter to recurse directories.
Add a note about updating TypeScript types (@qgustavor)
I always forget about that, so is better to put it in the readme.
Fix Deno tests (@qgustavor)
--allow-net should not include a trailing slash.
TS fix: find,filter,navigate in
storage
(@xmok)I'm not sure if the return type of
navigate
is correct - could anyone verify?.TS fix:
secondFactorCode
type was missing in Storage constructor (TS) (@xmok)Fix typo in the template (@qgustavor)
Improve bug report template (@qgustavor)