Default measurement for annealing for the first demo implementation. #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…qilimanjaro-tech/qililab into add-one-qubit-analog-transpiler
…quivalent to another
…ub.com/qilimanjaro-tech/qililab into create-annealingSchedule-class/QHC-636
…ub.com/qilimanjaro-tech/qililab into create-annealingSchedule-class/QHC-636
visagim
reviewed
Aug 21, 2024
visagim
reviewed
Aug 21, 2024
visagim
reviewed
Aug 21, 2024
visagim
reviewed
Aug 21, 2024
addressed, thanks! |
jjmartinezQT
deleted the
qhc-691-add-default-measurement-pulse-to-annealing-program
branch
jjmartinezQT
added a commit
that referenced
this pull request
Aug 21, 2024
…778) * add parameter class and one qubit analog transpiler * add unit tests * add unit tests * move fluqe parameter inside analog, fix pylint complains * draft of anneal program with transpiler for 1q * add analog program execution workflow * add changelog * fix mypy * fix docstring * add unit test for anneal program * wip platform unit tests * add to_dict method to qprogram in order to tests that a qprogram is equivalent to another * fix tests * fix pylint * fix docstrings, pylint * still trying to fix docs * still trying to fix the docs * still trying to fix the docs * still trying to fix the docs * change qprogram to_readable_dict to __str__ method * fix tests, fix docs * add suggested changes * add unittest for qprogram str method * fix tests * remove unused import * fix coverage * update changelog * implementation proposal * code quality * testing annealing * weights are optional * raising error * raises error test * QHC 621 Modify set_intermediate_frequency for the jobAPI (#764) * update to support opx1000 * fix import error * fix typo * add default type * fix typo * change octave connectivity * Implemented necessary changes for QUA/job API (#756) * Implemented necessary changes for QUA/job API * Update tests/instruments/quantum_machines/test_quantum_machines_cluster.py * FIXED AUTOMATIC FORMAT * add if_outputs * add if_outputs * opx1000 * corrected deprecated functions * fix typos and tests * fix code quality * Fixing Documentation warnings * allowing more than a QM existing at same time * Changes on the IF set * updated job type * ignored changes * pylint disabled * fix * formatted tests * Fixed isort issues * fix pylint * fix test * fix * added missing coverage * fixed change * Added octave calibrate_element after if / lo set * fixed tests * removed incorrect assertions * fixed black formatter * code quality * code quality * ignoring types * black * Ignoring job type * Make ignore typing only for `[union-attr]` * Rewritten job order to execute set_frequency * changed from job to self.job for tests and the future * Forgot a space :) * ADDED PYLINT EXCEPTION * Fixed Mypy * a¡changed type requirements * Added compatibility with opx+ and opx1000 * black * reset self._intermediate_frequency * fix test * fixed moretests * tests * created function to get the controller * black * added changelog * coverage * fixed tests * fix * test reaise error * pylint * Update src/qililab/instruments/quantum_machines/quantum_machines_cluster.py * Apply suggestions from code review Co-authored-by: Vyron Vasileiadis <hi@fedonman.com> * implemented suggested changes * black * fix tests * removed unexistent test --------- Co-authored-by: Vyron Vasileiads <hi@fedonman.com> Co-authored-by: Guillermo Abad López <109400222+GuillermoAbadLopez@users.noreply.github.com> Co-authored-by: GitHub Actions bot <actions@github.com> Co-authored-by: jjmartinezQT <133863373+jjmartinezQT@users.noreply.github.com> * tests * isort * measure in test * code quality * code quality * removing duplicate fixture * removing duplicate * disabling too many lines in platform * removing unused arguments * calibration fixture * code quality * fixing unittest * removing brackets typo * passing by calibration to execute_qprogram * refactoring * fixing unittest * removing comment * [QHC-636] Create AnnealingSchedule class in Qililab. (#767) * add parameter class and one qubit analog transpiler * add unit tests * add unit tests * move fluqe parameter inside analog, fix pylint complains * draft of anneal program with transpiler for 1q * add analog program execution workflow * add changelog * fix mypy * fix docstring * add unit test for anneal program * wip platform unit tests * add to_dict method to qprogram in order to tests that a qprogram is equivalent to another * fix tests * fix pylint * fix docstrings, pylint * still trying to fix docs * still trying to fix the docs * still trying to fix the docs * still trying to fix the docs * change qprogram to_readable_dict to __str__ method * fix tests, fix docs * add suggested changes * add unittest for qprogram str method * fix tests * remove unused import * fix coverage * update changelog * tests * returning changes lost * isort * measure in test * Revert "measure in test" This reverts commit 6dc9b07. * Revert "isort" This reverts commit a958ea8. * Revert "returning changes lost" This reverts commit 86a2bbd. * Revert "tests" This reverts commit d7d0669. --------- Co-authored-by: GitHub Actions bot <actions@github.com> * changelog * code quality * returning results of annealing * returning type * code quality * making calibration file non optional * introducing sync * code quality * code quality * outside loop * checking type * changing test * adding calibration * fixing unittest * checking return type * removing src * code quality --------- Co-authored-by: victor <visangim@gmail.com> Co-authored-by: GitHub Actions bot <actions@github.com> Co-authored-by: jordivallsq <151619025+jordivallsq@users.noreply.github.com> Co-authored-by: Vyron Vasileiads <hi@fedonman.com> Co-authored-by: Guillermo Abad López <109400222+GuillermoAbadLopez@users.noreply.github.com>
jjmartinezQT
added a commit
that referenced
this pull request
Aug 21, 2024
* update to support opx1000 * fix import error * fix typo * add default type * fix typo * change octave connectivity * Implemented necessary changes for QUA/job API (#756) * Implemented necessary changes for QUA/job API * Update tests/instruments/quantum_machines/test_quantum_machines_cluster.py * FIXED AUTOMATIC FORMAT * add if_outputs * add if_outputs * opx1000 * corrected deprecated functions * fix typos and tests * fix code quality * Fixing Documentation warnings * allowing more than a QM existing at same time * adding try, except * black * not bare except * changelog * removing duplicated code on merge * right program from import * fixing unittest from bad merge * testing raising error * code quality * fixing unittest * code quality * unittest * unittest * code quality * changing the execution * unittest * undoing * unittest * unittest * mocking cluster turn off * code quality * changing message * regex * regex * escaping error message * escaped error str * code quality * code quality * do not close machines * code quality * platform merge fix * merge arbitrary waveform hash fix from main * Default measurement for annealing for the first demo implementation. (#778) * add parameter class and one qubit analog transpiler * add unit tests * add unit tests * move fluqe parameter inside analog, fix pylint complains * draft of anneal program with transpiler for 1q * add analog program execution workflow * add changelog * fix mypy * fix docstring * add unit test for anneal program * wip platform unit tests * add to_dict method to qprogram in order to tests that a qprogram is equivalent to another * fix tests * fix pylint * fix docstrings, pylint * still trying to fix docs * still trying to fix the docs * still trying to fix the docs * still trying to fix the docs * change qprogram to_readable_dict to __str__ method * fix tests, fix docs * add suggested changes * add unittest for qprogram str method * fix tests * remove unused import * fix coverage * update changelog * implementation proposal * code quality * testing annealing * weights are optional * raising error * raises error test * QHC 621 Modify set_intermediate_frequency for the jobAPI (#764) * update to support opx1000 * fix import error * fix typo * add default type * fix typo * change octave connectivity * Implemented necessary changes for QUA/job API (#756) * Implemented necessary changes for QUA/job API * Update tests/instruments/quantum_machines/test_quantum_machines_cluster.py * FIXED AUTOMATIC FORMAT * add if_outputs * add if_outputs * opx1000 * corrected deprecated functions * fix typos and tests * fix code quality * Fixing Documentation warnings * allowing more than a QM existing at same time * Changes on the IF set * updated job type * ignored changes * pylint disabled * fix * formatted tests * Fixed isort issues * fix pylint * fix test * fix * added missing coverage * fixed change * Added octave calibrate_element after if / lo set * fixed tests * removed incorrect assertions * fixed black formatter * code quality * code quality * ignoring types * black * Ignoring job type * Make ignore typing only for `[union-attr]` * Rewritten job order to execute set_frequency * changed from job to self.job for tests and the future * Forgot a space :) * ADDED PYLINT EXCEPTION * Fixed Mypy * a¡changed type requirements * Added compatibility with opx+ and opx1000 * black * reset self._intermediate_frequency * fix test * fixed moretests * tests * created function to get the controller * black * added changelog * coverage * fixed tests * fix * test reaise error * pylint * Update src/qililab/instruments/quantum_machines/quantum_machines_cluster.py * Apply suggestions from code review Co-authored-by: Vyron Vasileiadis <hi@fedonman.com> * implemented suggested changes * black * fix tests * removed unexistent test --------- Co-authored-by: Vyron Vasileiads <hi@fedonman.com> Co-authored-by: Guillermo Abad López <109400222+GuillermoAbadLopez@users.noreply.github.com> Co-authored-by: GitHub Actions bot <actions@github.com> Co-authored-by: jjmartinezQT <133863373+jjmartinezQT@users.noreply.github.com> * tests * isort * measure in test * code quality * code quality * removing duplicate fixture * removing duplicate * disabling too many lines in platform * removing unused arguments * calibration fixture * code quality * fixing unittest * removing brackets typo * passing by calibration to execute_qprogram * refactoring * fixing unittest * removing comment * [QHC-636] Create AnnealingSchedule class in Qililab. (#767) * add parameter class and one qubit analog transpiler * add unit tests * add unit tests * move fluqe parameter inside analog, fix pylint complains * draft of anneal program with transpiler for 1q * add analog program execution workflow * add changelog * fix mypy * fix docstring * add unit test for anneal program * wip platform unit tests * add to_dict method to qprogram in order to tests that a qprogram is equivalent to another * fix tests * fix pylint * fix docstrings, pylint * still trying to fix docs * still trying to fix the docs * still trying to fix the docs * still trying to fix the docs * change qprogram to_readable_dict to __str__ method * fix tests, fix docs * add suggested changes * add unittest for qprogram str method * fix tests * remove unused import * fix coverage * update changelog * tests * returning changes lost * isort * measure in test * Revert "measure in test" This reverts commit 6dc9b07. * Revert "isort" This reverts commit a958ea8. * Revert "returning changes lost" This reverts commit 86a2bbd. * Revert "tests" This reverts commit d7d0669. --------- Co-authored-by: GitHub Actions bot <actions@github.com> * changelog * code quality * returning results of annealing * returning type * code quality * making calibration file non optional * introducing sync * code quality * code quality * outside loop * checking type * changing test * adding calibration * fixing unittest * checking return type * removing src * code quality --------- Co-authored-by: victor <visangim@gmail.com> Co-authored-by: GitHub Actions bot <actions@github.com> Co-authored-by: jordivallsq <151619025+jordivallsq@users.noreply.github.com> Co-authored-by: Vyron Vasileiads <hi@fedonman.com> Co-authored-by: Guillermo Abad López <109400222+GuillermoAbadLopez@users.noreply.github.com> --------- Co-authored-by: Vyron Vasileiads <hi@fedonman.com> Co-authored-by: jordivallsq <151619025+jordivallsq@users.noreply.github.com> Co-authored-by: jvallsq <jordi.valls@qilimanjaro.tech> Co-authored-by: Guillermo Abad López <109400222+GuillermoAbadLopez@users.noreply.github.com> Co-authored-by: GitHub Actions bot <actions@github.com> Co-authored-by: victor <visangim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the proposal for the default square measurement for annealing needed for the first demo.