-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QHC-833] Improving digital Transpilation #862
base: main
Are you sure you want to change the base?
Conversation
AI AnalysisReview:The changes in
|
optimization
word use in the transpilationoptimization
word use in the transpilation
optimization
word use in the transpilationTranspilation
Transpilation
Transpilation
Transpilation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
=======================================
Coverage 96.77% 96.78%
=======================================
Files 221 221
Lines 7756 7765 +9
=======================================
+ Hits 7506 7515 +9
Misses 250 250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…n compile and execute
TODOs for this PR:
(each of the next points is pretty big deal, so check them all please 🙌🙃)
optimize
flag, for actual optional optimizations (& Improveoptimize
word use in methods names)Transpilation
/execute
/compile
only for single circuits (unify code standard acrossqililab
)Transpilation
efficient, by not constructing theCircuit
class so many times, between methodskwargs
instead of so many args inplatform
/qililab
'sexecute(...)
execute()
's, and moving it to a new section.You will see two empty methods, in this next PR I will fill them:
bunch_drag_gates(...)
,delete_gates_with_no_amplitude(...)
The documentation after this PR looks like:
For the
platform.execute()
:For the module about
Transpilation
:For the
Transpiler.transpile_circuit()
: