Qhc 848 support iq modulation for r&s sgs100 a

[flavie-lebars]

No description provided.

[linear]

QHC-848 Incorporate R&S IQ modulation in Qililab.

[pullpo-for-slack]

🔗Pullpo.io Slack channel

[pullpo-for-slack]

AI Analysis

Review:

The changes in the test file seem to be adding new fixtures and test methods, which enhances the test coverage for the QDevil QDAC2 instrument. In the rohde_schwarz/sgs100a.py file, the addition of a new property and methods related to IQ state management seems like a meaningful enhancement to the functionality. The updates in qdevil_qdac2.py for defining ramping rates as constants and validating them in the set up methods contribute to better error handling and maintainability.

Detailed file changes

(dropdown):

In tests/instruments/qdevil/test_qdevil_qdac2.py:

• Added new fixtures qdac_out_range and waveform.
• Updated get_square_waveform fixture to return Square(0.1, 4).
• Added test methods: test_clear_cache, test_input_range_runcard, test_input_range_set_parameter, and test_input_range_set_parameter_enabled.

In src/qililab/instruments/rohde_schwarz/sgs100a.py:

• Added a new property IQ_state to the SGS100ASettings class.
• Added methods to set and get the IQ_STATE parameter in the SignalGenerator class.
• Updated the initial_setup method to include setting the IQ_state on the device.

In src/qililab/instruments/qdevil/qdevil_qdac2.py:

• Defined minimum and maximum ramping rates as class constants.
• Updated the set_parameter method to check if the ramp rate is within the valid range.
• Updated the initial_setup method to validate the ramp rate for each channel and raise a ValueError if it's out of range.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (f0a32d2) to head (2ae8d74).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #872   +/-   ##
=======================================
  Coverage   97.28%   97.29%           
=======================================
  Files         231      231           
  Lines        8219     8232   +13     
=======================================
+ Hits         7996     8009   +13     
  Misses        223      223           

Flag	Coverage Δ
unittests	97.29% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fedonman]

Everything looks good for me! Great work 💯

Made a suggestion on using an existing parameter.

[fedonman]

This enables hardware modulation, right? If yes, we have a Parameter.HARDWARE_MODULATION that we use in other instruments as well.

Let's verify this with measurements team.

[fedonman]

With the same concept, this could be modulation or hardware_modulation or similar.