Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove py.typed until #74 is addressed #121

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

woodsp-ibm
Copy link
Member

@woodsp-ibm woodsp-ibm commented Jan 11, 2024

Summary

Closes #114

Details and comments

#74 was created to improve typing - py,typed was removed from stable as without this being addressed its causing failures in the applications CI when running mypy. As noted in the issue #114 I think its best for now to remove it from main here until such time that #74 sorts/improves the typing.

@woodsp-ibm woodsp-ibm mentioned this pull request Jan 11, 2024
12 tasks
@coveralls
Copy link

coveralls commented Jan 11, 2024

Pull Request Test Coverage Report for Build 7555019544

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.578%

Totals Coverage Status
Change from base Build 7503681147: 0.0%
Covered Lines: 6470
Relevant Lines: 7143

💛 - Coveralls

@mergify mergify bot merged commit 8e99e06 into qiskit-community:main Jan 17, 2024
18 of 35 checks passed
@woodsp-ibm woodsp-ibm deleted the del_py.typed branch January 17, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove py.typed until #74 is addressed
3 participants