Scipy 1.14 compatibility fix #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsp-ibm
added
bug
Pull Request Test Coverage Report for Build 9724576922Details
💛 - Coveralls |
|
Note this is failing tests against unreleased qiskit main - see #181 for more info. |
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2024
(cherry picked from commit 3fb69b3)
This was referenced Jul 16, 2024
mrossinek
added a commit
to mrossinek/qiskit-nature-pyscf
that referenced
this pull request
Sep 4, 2024
This can be removed once `qiskit-algorithms` releases a new version which includes the fix there [1]. [1]: qiskit-community/qiskit-algorithms#184
mrossinek
added a commit
to qiskit-community/qiskit-nature-pyscf
that referenced
this pull request
Sep 4, 2024
* ci: update download-artifact action * ci: update black * ci: trigger * meta: constrain scipy This can be removed once `qiskit-algorithms` releases a new version which includes the fix there [1]. [1]: qiskit-community/qiskit-algorithms#184 * ci: fix mismatched upload-artifact action version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #182
Scipy 1.14 compatibility fix
Details and comments
Using .H from csr_matrix had been deprecated and has now been removed in scipy 1.14. This changes NumPyEigensolver, to use an alternative (and works with the prior scipy). This also ends up fixing CI which has been failing in nightly builds recently.