Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pylint disables #205

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Added pylint disables #205

merged 3 commits into from
Oct 2, 2024

Conversation

tnemoz
Copy link
Contributor

@tnemoz tnemoz commented Sep 24, 2024

Summary

This PR adds numerous pylint: disable to make the CI tests pass now that pylint has been upgraded to 3.3.0 for Python 3.9, as discussed here.

Details and comments

This may be a temporary fix only, as it is possible that some methods could be improved to satisfy the linter without having to disable it.

@coveralls
Copy link

coveralls commented Sep 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11032283116

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.444%
Totals Coverage Status
Change from base Build 10818121795: 0.0%
Covered Lines: 6370
Relevant Lines: 7043
💛 - Coveralls

@woodsp-ibm woodsp-ibm added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Oct 2, 2024
woodsp-ibm
woodsp-ibm approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing things. It looks good. I labelled it as Stable backport so as to get stable fixed too (a PR will then be automatically created by mergify on stable once this is merged from this) as these changes should be applicable there as well.

@mergify mergify bot merged commit 1a09ddb into qiskit-community:main Oct 2, 2024
21 checks passed
mergify bot pushed a commit that referenced this pull request Oct 2, 2024
@tnemoz @mergify
Added pylint disables (#205)
e6cecf2 
(cherry picked from commit 1a09ddb)
@mergify mergify bot mentioned this pull request Oct 2, 2024
Merged
woodsp-ibm pushed a commit that referenced this pull request Oct 2, 2024
@mergify @tnemoz
Added pylint disables (backport #205) (#206)
1f87537 
Co-authored-by: Tristan NEMOZ <36485441+tnemoz@users.noreply.github.com>
@tnemoz tnemoz deleted the lint branch October 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@Cryoris Cryoris Awaiting requested review from Cryoris Cryoris is a code owner

@ElePT ElePT Awaiting requested review from ElePT ElePT is a code owner

Assignees
No one assigned
Labels
automerge stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnemoz @coveralls @woodsp-ibm