Add ecosystem.json to include project in Qiskit ecosystem
#43
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,23 @@ | ||||||
| { | ||||||
| "dependencies_files": [ | ||||||
| "requirements.txt", | ||||||
| "requirements-dev.txt" | ||||||
| ], | ||||||
| "extra_dependencies": [ | ||||||
| "pytest" | ||||||
| ], | ||||||
| "language": { | ||||||
| "name": "python", | ||||||
| "versions": ["3.9"] | ||||||
| }, | ||||||
| "tests_command": [ | ||||||
| "pytest" | ||||||
|
There was a problem hiding this comment. Couldn't we just defer this to the Makefile we have already? So
Suggested change
There was a problem hiding this comment. Just keep in mind in Ecosystem we launch it inside a tox env, so keep it as simple and basic as possible :) There was a problem hiding this comment. You'll need to add : "debian_dependencies": [
"make"
],The feature is actually in review process |
||||||
| ], | ||||||
| "styles_check_command": [ | ||||||
| "pylint -rn src tests" | ||||||
|
There was a problem hiding this comment. Likewise this could maybe be
Suggested change
There was a problem hiding this comment. Just keep in mind in Ecosystem we launch it inside a tox env, so keep it as simple and basic as possible :) There was a problem hiding this comment. You'll need to add : "debian_dependencies": [
"make"
],The feature is actually in review process |
||||||
| ], | ||||||
| "coverages_check_command": [ | ||||||
| "coverage3 run -m pytest", | ||||||
| "coverage3 report --fail-under=80" | ||||||
| ] | ||||||
| } | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the test dependencies are in
requirements-dev.txtwhich is in the dependencies above, maybe we don't need this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check it, what do you mean ?
I even don't see pytest in your 2 files