Short import for TrotterQRTE #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5952742547
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While we allowed the new VQE etc to be imported from qiskit_algorithms the new TrotterQRTE was overlooked. It can now be imported from qiskit_algorithms so you do not need to import it from the sub-module, but that still works for any code that does.
Updated the docs so TrotterQRTE is documented at that level along with the other algorithms. Also made a couple of highlighted and plain text items class refs to the content so they become links.
Also the docstring stated the default was LieTrotter with reps=1 but was relying on the default value in LieTrotter being 1 to make this so. I set it explicitly just in case the default in the constructor ever gets changed.
Details and comments