Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating qiskit_algorithms #817

Merged
merged 69 commits into from
Aug 13, 2024
Merged

Conversation

edoaltamura
Copy link
Collaborator

Summary

Qiskit algorithms, which Qiskit machine-learning (ML) depends on, is no longer officially supported as of qiskit-community/qiskit-algorithms@4247d06. To continue improving the subset of Algorithms features that are relevant to Qiskit machine-learning, it has been proposed to migrate those from Algorithms to ML.

This PR implements the merge of the subset of Qiskit Algorithms features needed for ML, as described in #811.

Closes #811.

  • qiskit_algorithms/gradients -> qiskit_machine_learning/gradients
  • qiskit_algorithms/optimizers -> qiskit_machine_learning/optimizers
  • qiskit_algorithms/state_fidelities -> qiskit_machine_learning/state_fidelities
  • qiskit_algorithms/utils partially merged with qiskit_machine_learning/utils

Details and comments

The unit tests are also merged following the same structure as in the source directory.

  • qiskit_algorithms/tests/gradients -> qiskit_machine_learning/tests/gradients
  • qiskit_algorithms/tests/optimizers -> qiskit_machine_learning/tests/optimizers
  • qiskit_algorithms/tests/state_fidelities -> qiskit_machine_learning/tests/state_fidelities
  • qiskit_algorithms/tests/utils partially merged with qiskit_machine_learning/tests/utils

Once the merge is complete, the codebase will be ready for a targeted attempt at resolving:

…te.py

Co-authored-by: Declan Millar <declan.millar@ibm.com>
@coveralls
Copy link

coveralls commented Aug 1, 2024

Pull Request Test Coverage Report for Build 10265294737

Details

  • 2673 of 2923 (91.45%) changed or added relevant lines in 81 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 91.7%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_machine_learning/optimizers/nlopts/crs.py 3 4 75.0%
qiskit_machine_learning/optimizers/nlopts/direct_l.py 3 4 75.0%
qiskit_machine_learning/optimizers/nlopts/direct_l_rand.py 3 4 75.0%
qiskit_machine_learning/optimizers/nlopts/esch.py 3 4 75.0%
qiskit_machine_learning/optimizers/nlopts/isres.py 3 4 75.0%
qiskit_machine_learning/algorithm_job.py 5 7 71.43%
qiskit_machine_learning/gradients/lin_comb/lin_comb_qgt.py 93 95 97.89%
qiskit_machine_learning/gradients/lin_comb/lin_comb_sampler_gradient.py 56 58 96.55%
qiskit_machine_learning/gradients/param_shift/param_shift_estimator_gradient.py 37 39 94.87%
qiskit_machine_learning/gradients/param_shift/param_shift_sampler_gradient.py 43 45 95.56%
Totals Coverage Status
Change from base Build 10160486542: -0.5%
Covered Lines: 4640
Relevant Lines: 5060

💛 - Coveralls

Copy link
Contributor

@declanmillar declanmillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor style suggestion. Otherwise, LGTM.

@edoaltamura edoaltamura mentioned this pull request Aug 6, 2024
@declanmillar
Copy link
Contributor

LGTM. Thanks again :)

Copy link
Collaborator

@OkuyanBoga OkuyanBoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to go. Thanks @edoaltamura

@OkuyanBoga OkuyanBoga merged commit 094b994 into qiskit-community:main Aug 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 🔗 Involves external dependency libraries priority: high type: design 📐 Relevant to code architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate qiskit_algorithms following end-of-support
6 participants