-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating qiskit_algorithms
#817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torch issue716
…te.py Co-authored-by: Declan Millar <declan.millar@ibm.com>
woodsp-ibm
reviewed
Aug 2, 2024
releasenotes/notes/qiskit-algorithms-incorporated-421554a4ff547d0d.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/qiskit-algorithms-incorporated-421554a4ff547d0d.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/qiskit-algorithms-incorporated-421554a4ff547d0d.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/qiskit-algorithms-incorporated-421554a4ff547d0d.yaml
Outdated
Show resolved
Hide resolved
declanmillar
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a minor style suggestion. Otherwise, LGTM.
releasenotes/notes/qiskit-algorithms-incorporated-421554a4ff547d0d.yaml
Outdated
Show resolved
Hide resolved
Merged
declanmillar
reviewed
Aug 6, 2024
releasenotes/notes/qiskit-algorithms-incorporated-421554a4ff547d0d.yaml
Outdated
Show resolved
Hide resolved
LGTM. Thanks again :) |
OkuyanBoga
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good to go. Thanks @edoaltamura
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies 🔗
Involves external dependency libraries
priority: high
type: design 📐
Relevant to code architecture
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Qiskit algorithms, which Qiskit machine-learning (ML) depends on, is no longer officially supported as of qiskit-community/qiskit-algorithms@4247d06. To continue improving the subset of Algorithms features that are relevant to Qiskit machine-learning, it has been proposed to migrate those from Algorithms to ML.
This PR implements the merge of the subset of Qiskit Algorithms features needed for ML, as described in #811.
Closes #811.
qiskit_algorithms/gradients
->qiskit_machine_learning/gradients
qiskit_algorithms/optimizers
->qiskit_machine_learning/optimizers
qiskit_algorithms/state_fidelities
->qiskit_machine_learning/state_fidelities
qiskit_algorithms/utils
partially merged withqiskit_machine_learning/utils
Details and comments
The unit tests are also merged following the same structure as in the source directory.
qiskit_algorithms/tests/gradients
->qiskit_machine_learning/tests/gradients
qiskit_algorithms/tests/optimizers
->qiskit_machine_learning/tests/optimizers
qiskit_algorithms/tests/state_fidelities
->qiskit_machine_learning/tests/state_fidelities
qiskit_algorithms/tests/utils
partially merged withqiskit_machine_learning/tests/utils
Once the merge is complete, the codebase will be ready for a targeted attempt at resolving: