-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.7 support #538
Conversation
pyproject.toml and tox.ini both have |
Pull Request Test Coverage Report for Build 5940174572
💛 - Coveralls |
@woodsp-ibm I guess we need to configure somewhere to update the following entries to Python 3.8. Do you have any ideas? We can update the configuration after merging this PR. |
@t-imamichi They are edited under the Settings for the repo - select Branches from the left and you will see Branch Protection Rules and you can Edit the rules for the main branch. Should probably make sure the new 3.11 tutorials is required too. Once you edit the rules the checks here should alter accordingly. (I think all the checks listed we have as required normally - except the Summary one mergify puts in there). Don't forget also the comment above about the two other files that should be updated - i.e the removal of py37 in them now that this drops 3.7 support etc. |
Thanks. I succeeded in updating the configuration. |
Looks good, just missing these two file being updated to remove Line 3 in 3f21208
qiskit-optimization/pyproject.toml Line 7 in 3f21208
And I note in the latter (pyproject.toml) we forgot to add py311 to that list for black so maybe that can be added, and we can fix it here, while removing the py37 |
Thanks. I updated tox.ini and pyproject.toml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Qiskit has dropped support Python 3.7 and this follows suit for Qiskit Optimization.
follows qiskit-community/qiskit-finance#288
depends on #536
Details and comments