Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library upgrades #385

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Library upgrades #385

merged 1 commit into from
Sep 19, 2023

Conversation

grace-harper
Copy link
Collaborator

@grace-harper grace-harper commented Sep 13, 2023

Summary

Upgraded to qiskit-terra>=0.24.0
Removed cap on pylint
Added compatibility for numpy>=1.25.0

Details and comments

Pylint

We removed the cap on pylint version (previously pylint==2.11.1)

Qiskit Terra

In order for qiskit.quantum_info to be compatible with numpy>=1.25.0, we had to upgrade to qiskit-terra>=1.24.0 which required removing support in qiskit-qec for legacy qiskit.quantum_info classes: qiskit.quantum_info.operators.symplectic.stabilizer_table.StabilizerTable
qiskit.quantum_info.operators.symplectic.pauli_table.PauliTable
qiskit.quantum_info.operators.symplectic.clifford.Clifford
Previously, any code using these functions was self-contained and we had no users who needed this functionality maintained.

Numpy 1.25.0

numpy>=1.25.0 no longer autoconverts non 0-dim np.ndarrays to scalars when necessary so, in reference to #380 and #383, we manually handled those edges, which occurred in PauliList when dealing with Pauli._phase_exp

@grace-harper grace-harper changed the title Pauli _phase_exp as (1,1) numpy.ndarray edgecase Upgrade to Numpy 1.25 Sep 14, 2023
@grace-harper grace-harper changed the title Upgrade to Numpy 1.25 Library upgrades to allow Numpy 1.25 Sep 14, 2023
@grace-harper grace-harper changed the title Library upgrades to allow Numpy 1.25 Library upgrades Sep 14, 2023
@grace-harper grace-harper requested review from IceKhan13, quantumjim and dsvandet and removed request for IceKhan13 September 14, 2023 20:41
@grace-harper grace-harper self-assigned this Sep 14, 2023
Copy link
Collaborator

@dsvandet dsvandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for come changes.

Removed cap on pylint
Added compatibility for numpy>=1.25.0
Copy link
Collaborator

@dsvandet dsvandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grace-harper grace-harper marked this pull request as draft September 19, 2023 15:53
@grace-harper grace-harper marked this pull request as ready for review September 19, 2023 16:03
@grace-harper grace-harper marked this pull request as draft September 19, 2023 16:05
Copy link
Collaborator

@dsvandet dsvandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

grace-harper added a commit that referenced this pull request Oct 2, 2023
Removed cap on pylint
Added compatibility for numpy>=1.25.0

Co-authored-by: Grace <grace.harper@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants