chore: clean up accumulated vue warnings

qmk · Oct 29, 2023 · 14699e3 · 14699e3
1 parent db4e127
commit 14699e3
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 25 deletions.
diff --git a/src/components/AnyKey.vue b/src/components/AnyKey.vue
@@ -15,14 +15,14 @@
     @dragenter.prevent="dragenter"
   ><div :class="`${hasFocus ? 'key-layer-title-focus' : 'key-layer-title'}`">{{ displayName }}<div><input
   v-if="isShowingKeymapLegends"
+  ref="input"
+  v-model="value" 
+  :style="`width:calc(${this.charLength}ch + 6px);`"
   class="key-layer-input"
+  spellcheck="false"
   @focus.prevent.stop="focus"
   @blur.prevent.stop="blur"
-  @click.prevent.stop="clickignore"
-  ref="input"
-  spellcheck="false"
-  :style="`width:calc(${this.charLength}ch + 6px);`"
-  v-model="value" /></div></div><div
+  @click.prevent.stop="clickignore" /></div></div><div
         v-if="visible"
         class="remove"
         @click.stop="remove"
@@ -32,7 +32,7 @@
 import { mapMutations } from 'vuex';
 import BaseKey from './BaseKey.vue';
 export default {
-  name: 'any-key',
+  name: 'AnyKey',
   extends: BaseKey,
   data() {
     return {

diff --git a/src/components/BaseKey.vue b/src/components/BaseKey.vue
@@ -1,8 +1,8 @@
 <template>
   <!-- prettier-ignore -->
   <div
-    draggable
     :id="myid"
+    draggable
     class="key"
     :class="myclasses"
     :style="mystyles"
@@ -99,27 +99,64 @@ const getKeySizeClass = (unitheight, unitwidth) => {
 };
 
 export default {
-  name: 'base-key',
+  name: 'BaseKey',
   props: {
-    id: Number,
-    meta: Object,
-    w: Number,
-    h: Number,
-    y: Number,
-    x: Number,
-    uh: Number,
-    uw: Number,
-    colorway: String,
+    id: {
+      type: Number,
+      default: 0
+    },
+    meta: {
+      type: Object,
+      default: () => {}
+    },
+    w: {
+      type: Number,
+      default: 0
+    },
+    h: {
+      type: Number,
+      default: 0
+    },
+    y: {
+      type: Number,
+      default: 0
+    },
+    x: {
+      type: Number,
+      default: 0
+    },
+    uh: {
+      type: Number,
+      default: 0
+    },
+    uw: {
+      type: Number,
+      default: 0
+    },
+    colorway: {
+      type: String,
+      default: ''
+    },
     legends: {
       type: String,
       default: 'keymap'
     },
-    matrix: Array,
+    matrix: {
+      type: Array,
+      default: () => []
+    },
     printable: {
       type: Boolean,
       default: false
     }
   },
+  data() {
+    return {
+      inHover: false,
+      inSwap: false,
+      platform: undefined
+    };
+  },
   computed: {
     ...mapState('keymap', ['config']),
     ...mapState('keymap', { curLayer: 'layer' }),
@@ -324,13 +361,6 @@ export default {
       }
       this.setSelectedContent(id);
     }
-  },
-  data() {
-    return {
-      inHover: false,
-      inSwap: false,
-      platform: undefined
-    };
   }
 };
 </script>