Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust width requirement for big enter #1284

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jul 7, 2023

Description

Configurator-side changes for qmk/qmk_firmware#21470

@fauxpark fauxpark requested a review from a team July 7, 2023 11:59
@yanfali
Copy link
Collaborator

yanfali commented Jul 7, 2023

Add a screenshot pls

@fauxpark
Copy link
Member Author

fauxpark commented Jul 7, 2023

There's no visual change, however now that the above PR has been merged, BAE keys should be rendering improperly now (which is what this is fixing). Example: gvalchca/spaccboard:LAYOUT_bae

Oddly the info.json requested from the Configurator has a timestamp of 2023-07-07 12:13:34 GMT with the old key size but if I request manually it's 2023-07-07 14:11:44 GMT and correct. Even completely restarting Firefox (also tried Chrome) doesn't change it.

@fauxpark
Copy link
Member Author

fauxpark commented Jul 7, 2023

Okay, whatever caching stuff was happening has expired now apparently:
image

@yanfali
Copy link
Collaborator

yanfali commented Jul 7, 2023

weird. I could have sworn those used to render.

@fauxpark
Copy link
Member Author

fauxpark commented Jul 7, 2023

They did. See the linked PR.

@fauxpark fauxpark merged commit f033623 into master Jul 8, 2023
@fauxpark fauxpark deleted the bae-render-adjustment branch July 8, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants