Remove unused ISO toggle code #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
precondition
force-pushed
the
removeConfiguratorSettingsISO
branch
from
e1aaee5
to
3cadf8f
Compare
precondition
changed the title
|
It's good to have screenshots to accompany UI changes. I'll try and review this today. |
yanfali
approved these changes
Oct 28, 2023
|
I just realized that calling If you remove it, going from "English (USA)" (ANSI) to "Estonian (Estonia)" (ISO) will change the order of the tabs as expected but the ANSI will remain selected. The current behavior (without this PR) is to also change the selected tab to be ISO. To keep the same behavior, I reverted that change in f0d5c2a. |
I'm not seeing any UI changes here. Near as I can tell, this is all orphaned code. |
noroadsleft
approved these changes
Oct 28, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused code related to the Settings Panel ISO toggle, rendered obsolete by the addition of host OS keyboard layout support.
Note that this does not remove
configuratorSettings.isobecause it it still a helpful flag to use for the communication between the keycode updating logic and the key tester updating logic. The key tester must automatically switch between ISO and ANSI depending on what's the standard physical geometry for a given national layout. I initially wanted to removeconfiguratorSettings.isoas well but I forgot about that auto-layout-change behaviour from the key tester, hence the misleading branch name.