Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore QMK icon #1319

Merged
merged 1 commit into from
Oct 28, 2023
Merged

fix: restore QMK icon #1319

merged 1 commit into from
Oct 28, 2023

Conversation

yanfali
Copy link
Collaborator

@yanfali yanfali commented Oct 28, 2023

  • the build process wasn't able to resolve the css path for the build icon. The quickest fix was to just move the icon file to public, this ensures it's always copied when making the dist.
  • fixed some warnings in App.vue about ordering of tags
  • moved the relevant CSS in App.vue
  • removed unused file
  • updated caniuse db

Description

@yanfali
fix: restore QMK icon
402113a 
 - the build process wasn't able to resolve the css path for the build
   icon. The quickest fix was to just move the icon file to public,
   this ensures it's always copied when making the dist.
 - fixed some warnings in App.vue about ordering of tags
 - moved the relevant CSS in App.vue
 - removed unused file
 - updated caniuse db
noroadsleft
noroadsleft approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. :)

@noroadsleft noroadsleft merged commit b10afe3 into master Oct 28, 2023
2 checks passed
@noroadsleft noroadsleft deleted the misc-fixes branch October 28, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanfali @noroadsleft