Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add args to Transition #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okhowang
Copy link
Contributor

@okhowang okhowang commented Jun 1, 2021

related #16

@qmuntal
Copy link
Owner

qmuntal commented Jun 3, 2021

Can you specify why you need the arguments in the Transition? They are normally already passed in the function call-backs.

@okhowang
Copy link
Contributor Author

okhowang commented Jun 3, 2021

I want write log once state changed
for debugging state machine.
And args is the detail info of transition.

@qmuntal
Copy link
Owner

qmuntal commented Jun 13, 2021

I'm hesitant to add the Arguments property to Transition. It does make sense but there are already many callbacks whose parameters are a transition and the arguments, so it would be confusing to have the arguments in both place.

Yet your use case is valid, so I will think on a way to cover it. Other proposals are also welcomed.

@okhowang
Copy link
Contributor Author

okhowang commented Aug 3, 2022

@qmuntal is any better way here?

@okhowang okhowang force-pushed the transition-arguments branch from 7acb6d9 to 640ab36 Compare April 29, 2024 07:27
@okhowang okhowang force-pushed the transition-arguments branch from 640ab36 to d121196 Compare April 29, 2024 07:37
@okhowang
Copy link
Contributor Author

okhowang commented May 3, 2024

@qmuntal is any better way here after 2 years?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants