Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't specialize integrate on df #423

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Don't specialize integrate on df #423

merged 1 commit into from
Oct 17, 2024

Conversation

amilsted
Copy link
Collaborator

Should save on compilation.

@github-actions GitHub Actions
Copy link
Contributor

Benchmark Result

Judge result

Benchmark Report for /home/runner/work/QuantumOptics.jl/QuantumOptics.jl

Job Properties

  • Time of benchmarks:
  • Target: 17 Oct 2024 - 16:44
  • Baseline: 17 Oct 2024 - 16:48
  • Package commits:
  • Target: acd562
  • Baseline: 8fe86a
  • Julia commits:
  • Target: 6f3fdf
  • Baseline: 6f3fdf
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["master", "base array types", "100//1"] 0.92 (5%) ✅ 1.00 (1%)
["master", "qo types", "100//1"] 0.93 (5%) ✅ 1.00 (1%)
["schroedinger", "base array types", "1//2"] 0.89 (5%) ✅ 1.00 (1%)
["schroedinger", "qo types", "1//2"] 0.86 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["master", "base array types"]
  • ["master", "qo types"]
  • ["schroedinger", "base array types"]
  • ["schroedinger", "qo types"]
  • ["stochastic master", "base array types"]
  • ["stochastic master", "qo types"]
  • ["stochastic schroedinger", "base array types"]
  • ["stochastic schroedinger", "qo types"]

Julia versioninfo

Target

Julia Version 1.10.5
Commit 6f3fdf7b362 (2024-08-27 14:19 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.5 LTS
 uname: Linux 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3115 MHz 3392 s 0 s 252 s 5949 s 0 s
 #2 2536 MHz 3630 s 0 s 244 s 5716 s 0 s
 #3 2445 MHz 4200 s 0 s 256 s 5127 s 0 s
 #4 3244 MHz 4054 s 0 s 241 s 5294 s 0 s
 Memory: 15.606491088867188 GB (13243.05078125 MB free)
 Uptime: 962.96 sec
 Load Avg: 1.11 1.29 1.12
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.5
Commit 6f3fdf7b362 (2024-08-27 14:19 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.5 LTS
 uname: Linux 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 4150 s 0 s 291 s 7690 s 0 s
 #2 3242 MHz 4645 s 0 s 300 s 7185 s 0 s
 #3 2601 MHz 4524 s 0 s 281 s 7317 s 0 s
 #4 2445 MHz 4436 s 0 s 274 s 7417 s 0 s
 Memory: 15.606491088867188 GB (12974.44140625 MB free)
 Uptime: 1217.31 sec
 Load Avg: 1.03 1.13 1.09
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/QuantumOptics.jl/QuantumOptics.jl

Job Properties

  • Time of benchmark: 17 Oct 2024 - 16:44
  • Package commit: acd562
  • Julia commit: 6f3fdf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["master", "base array types", "1//2"] 33.382 μs (5%) 28.50 KiB (1%) 279
["master", "base array types", "100//1"] 15.990 s (5%) 75.446 ms 11.65 GiB (1%) 77362
["master", "base array types", "20//1"] 38.707 ms (5%) 29.58 MiB (1%) 4570
["master", "base array types", "50//1"] 1.096 s (5%) 6.463 ms 836.56 MiB (1%) 21466
["master", "qo types", "1//2"] 35.096 μs (5%) 30.23 KiB (1%) 374
["master", "qo types", "100//1"] 13.619 s (5%) 71.757 ms 11.66 GiB (1%) 96829
["master", "qo types", "20//1"] 30.952 ms (5%) 29.84 MiB (1%) 5749
["master", "qo types", "50//1"] 887.175 ms (5%) 5.667 ms 838.12 MiB (1%) 26869
["schroedinger", "base array types", "1//2"] 6.131 μs (5%) 4.25 KiB (1%) 54
["schroedinger", "base array types", "100//1"] 3.090 ms (5%) 55.75 KiB (1%) 54
["schroedinger", "base array types", "20//1"] 126.635 μs (5%) 14.25 KiB (1%) 54
["schroedinger", "base array types", "50//1"] 651.379 μs (5%) 31.00 KiB (1%) 54
["schroedinger", "qo types", "1//2"] 5.327 μs (5%) 4.17 KiB (1%) 50
["schroedinger", "qo types", "100//1"] 2.953 ms (5%) 49.23 KiB (1%) 50
["schroedinger", "qo types", "20//1"] 209.128 μs (5%) 12.92 KiB (1%) 50
["schroedinger", "qo types", "50//1"] 737.779 μs (5%) 27.58 KiB (1%) 50
["stochastic master", "base array types", "1//2"] 274.219 μs (5%) 201.98 KiB (1%) 1947
["stochastic master", "base array types", "100//1"] 316.094 ms (5%) 857.972 μs 224.51 MiB (1%) 1605
["stochastic master", "base array types", "20//1"] 21.812 ms (5%) 15.46 MiB (1%) 2533
["stochastic master", "base array types", "50//1"] 90.939 ms (5%) 65.50 MiB (1%) 1829
["stochastic master", "qo types", "1//2"] 294.997 μs (5%) 222.67 KiB (1%) 2908
["stochastic master", "qo types", "100//1"] 516.599 ms (5%) 1.672 ms 398.44 MiB (1%) 3554
["stochastic master", "qo types", "20//1"] 20.107 ms (5%) 16.77 MiB (1%) 3554
["stochastic master", "qo types", "50//1"] 120.355 ms (5%) 100.75 MiB (1%) 3554
["stochastic schroedinger", "base array types", "1//2"] 45.775 μs (5%) 4.30 KiB (1%) 57
["stochastic schroedinger", "base array types", "100//1"] 1.056 ms (5%) 68.62 KiB (1%) 197
["stochastic schroedinger", "base array types", "20//1"] 237.240 μs (5%) 14.30 KiB (1%) 57
["stochastic schroedinger", "base array types", "50//1"] 556.553 μs (5%) 31.05 KiB (1%) 57
["stochastic schroedinger", "qo types", "1//2"] 51.486 μs (5%) 19.81 KiB (1%) 388
["stochastic schroedinger", "qo types", "100//1"] 1.417 ms (5%) 71.31 KiB (1%) 388
["stochastic schroedinger", "qo types", "20//1"] 313.652 μs (5%) 29.81 KiB (1%) 388
["stochastic schroedinger", "qo types", "50//1"] 721.972 μs (5%) 46.56 KiB (1%) 388

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["master", "base array types"]
  • ["master", "qo types"]
  • ["schroedinger", "base array types"]
  • ["schroedinger", "qo types"]
  • ["stochastic master", "base array types"]
  • ["stochastic master", "qo types"]
  • ["stochastic schroedinger", "base array types"]
  • ["stochastic schroedinger", "qo types"]

Julia versioninfo

Julia Version 1.10.5
Commit 6f3fdf7b362 (2024-08-27 14:19 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.5 LTS
 uname: Linux 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3115 MHz 3392 s 0 s 252 s 5949 s 0 s
 #2 2536 MHz 3630 s 0 s 244 s 5716 s 0 s
 #3 2445 MHz 4200 s 0 s 256 s 5127 s 0 s
 #4 3244 MHz 4054 s 0 s 241 s 5294 s 0 s
 Memory: 15.606491088867188 GB (13243.05078125 MB free)
 Uptime: 962.96 sec
 Load Avg: 1.11 1.29 1.12
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/QuantumOptics.jl/QuantumOptics.jl

Job Properties

  • Time of benchmark: 17 Oct 2024 - 16:48
  • Package commit: 8fe86a
  • Julia commit: 6f3fdf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["master", "base array types", "1//2"] 34.504 μs (5%) 28.50 KiB (1%) 279
["master", "base array types", "100//1"] 17.396 s (5%) 328.215 ms 11.65 GiB (1%) 77362
["master", "base array types", "20//1"] 37.682 ms (5%) 29.58 MiB (1%) 4570
["master", "base array types", "50//1"] 1.098 s (5%) 7.907 ms 836.56 MiB (1%) 21466
["master", "qo types", "1//2"] 36.788 μs (5%) 30.23 KiB (1%) 374
["master", "qo types", "100//1"] 14.679 s (5%) 250.637 ms 11.66 GiB (1%) 96829
["master", "qo types", "20//1"] 30.881 ms (5%) 29.84 MiB (1%) 5749
["master", "qo types", "50//1"] 925.458 ms (5%) 6.396 ms 838.12 MiB (1%) 26869
["schroedinger", "base array types", "1//2"] 6.927 μs (5%) 4.25 KiB (1%) 54
["schroedinger", "base array types", "100//1"] 3.064 ms (5%) 55.75 KiB (1%) 54
["schroedinger", "base array types", "20//1"] 127.737 μs (5%) 14.25 KiB (1%) 54
["schroedinger", "base array types", "50//1"] 659.744 μs (5%) 31.00 KiB (1%) 54
["schroedinger", "qo types", "1//2"] 6.193 μs (5%) 4.17 KiB (1%) 50
["schroedinger", "qo types", "100//1"] 2.914 ms (5%) 49.23 KiB (1%) 50
["schroedinger", "qo types", "20//1"] 210.511 μs (5%) 12.92 KiB (1%) 50
["schroedinger", "qo types", "50//1"] 736.587 μs (5%) 27.58 KiB (1%) 50
["stochastic master", "base array types", "1//2"] 273.999 μs (5%) 201.98 KiB (1%) 1947
["stochastic master", "base array types", "100//1"] 313.604 ms (5%) 828.238 μs 224.51 MiB (1%) 1605
["stochastic master", "base array types", "20//1"] 21.700 ms (5%) 15.46 MiB (1%) 2533
["stochastic master", "base array types", "50//1"] 90.812 ms (5%) 65.50 MiB (1%) 1829
["stochastic master", "qo types", "1//2"] 302.972 μs (5%) 222.67 KiB (1%) 2908
["stochastic master", "qo types", "100//1"] 541.580 ms (5%) 2.402 ms 398.44 MiB (1%) 3554
["stochastic master", "qo types", "20//1"] 20.259 ms (5%) 16.77 MiB (1%) 3554
["stochastic master", "qo types", "50//1"] 121.363 ms (5%) 1.585 ms 100.75 MiB (1%) 3554
["stochastic schroedinger", "base array types", "1//2"] 44.824 μs (5%) 4.30 KiB (1%) 57
["stochastic schroedinger", "base array types", "100//1"] 1.046 ms (5%) 68.62 KiB (1%) 197
["stochastic schroedinger", "base array types", "20//1"] 238.323 μs (5%) 14.30 KiB (1%) 57
["stochastic schroedinger", "base array types", "50//1"] 557.135 μs (5%) 31.05 KiB (1%) 57
["stochastic schroedinger", "qo types", "1//2"] 52.658 μs (5%) 19.81 KiB (1%) 388
["stochastic schroedinger", "qo types", "100//1"] 1.419 ms (5%) 71.31 KiB (1%) 388
["stochastic schroedinger", "qo types", "20//1"] 313.923 μs (5%) 29.81 KiB (1%) 388
["stochastic schroedinger", "qo types", "50//1"] 718.293 μs (5%) 46.56 KiB (1%) 388

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["master", "base array types"]
  • ["master", "qo types"]
  • ["schroedinger", "base array types"]
  • ["schroedinger", "qo types"]
  • ["stochastic master", "base array types"]
  • ["stochastic master", "qo types"]
  • ["stochastic schroedinger", "base array types"]
  • ["stochastic schroedinger", "qo types"]

Julia versioninfo

Julia Version 1.10.5
Commit 6f3fdf7b362 (2024-08-27 14:19 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.5 LTS
 uname: Linux 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 4150 s 0 s 291 s 7690 s 0 s
 #2 3242 MHz 4645 s 0 s 300 s 7185 s 0 s
 #3 2601 MHz 4524 s 0 s 281 s 7317 s 0 s
 #4 2445 MHz 4436 s 0 s 274 s 7417 s 0 s
 Memory: 15.606491088867188 GB (12974.44140625 MB free)
 Uptime: 1217.31 sec
 Load Avg: 1.03 1.13 1.09
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 4
On-line CPU(s) list: 0-3
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7763 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4890.86
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 1 MiB (2 instances)
L3 cache: 32 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Vulnerable: Safe RET, no microcode
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

Krastanov
Krastanov approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amilsted amilsted merged commit 1cff06f into master Oct 17, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krastanov Krastanov Krastanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amilsted @Krastanov