解决在RelativeLayout等依赖view id的布局中findViewById的错误 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenChoi1992
reviewed
Nov 25, 2020
| @@ -155,7 +155,7 @@ public Badge bindTarget(final View targetView) { | |||
| ViewGroup.LayoutParams targetParams = targetView.getLayoutParams(); | |||
| targetContainer.removeView(targetView); | |||
| final BadgeContainer badgeContainer = new BadgeContainer(getContext()); | |||
| if(targetContainer instanceof RelativeLayout){ | |||
| if (targetContainer instanceof RelativeLayout) { | |||
There was a problem hiding this comment.
这里是不是可以直接去掉 instanceof 的判断，把新增的 BadgeContainer id 直接变成原来 targetView 的 id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原理：从findViewById的源码中可以看出，最终调用的是findViewTraversal，因此重写BadgeContainer的findViewTraversal的查找逻辑，即可完美解决依赖id的View布局导致的findViewById错误！