Merge pull request #16 from quantum-sec/feature/EN-949

EN-949: remove default values (patch)

modules/azure-network-security-rule/README.md

@@ -27,18 +27,18 @@ No modules.
 |------|-------------|------|---------|:--------:|
 | <a name="input_access"></a> [access](#input\_access) | Specifies whether network traffic is allowed or denied. | `string` | n/a | yes |
 | <a name="input_description"></a> [description](#input\_description) | A description for this rule. | `string` | `null` | no |
-| <a name="input_destination_address"></a> [destination\_address](#input\_destination\_address) | destination\_address\_prefix - CIDR or destination IP range or `*` to match any IP. Tags such as `VirtualNetwork`, `AzureLoadBalancer` and `Internet` can also be used.<br>destination\_address\_prefixes - List of destination address prefixes. Tags may not be used. | <pre>object({<br>    prefix   = optional(string)<br>    prefixes = optional(set(string))<br>  })</pre> | <pre>{<br>  "prefix": null,<br>  "prefixes": null<br>}</pre> | no |
+| <a name="input_destination_address"></a> [destination\_address](#input\_destination\_address) | destination\_address\_prefix - CIDR or destination IP range or `*` to match any IP. Tags such as `VirtualNetwork`, `AzureLoadBalancer` and `Internet` can also be used.<br>destination\_address\_prefixes - List of destination address prefixes. Tags may not be used. | <pre>object({<br>    prefix   = optional(string)<br>    prefixes = optional(set(string))<br>  })</pre> | n/a | yes |
 | <a name="input_destination_application_security_group_ids"></a> [destination\_application\_security\_group\_ids](#input\_destination\_application\_security\_group\_ids) | List of destination Application Security Group ID's. | `set(string)` | `null` | no |
-| <a name="input_destination_port"></a> [destination\_port](#input\_destination\_port) | destination\_port\_range - Destination Port or Range. Integer or range between `0` and `65535` or `*` to match any.<br>destination\_port\_ranges - List of destination ports or port ranges. | <pre>object({<br>    range  = optional(string)<br>    ranges = optional(set(string))<br>  })</pre> | <pre>{<br>  "range": null,<br>  "ranges": null<br>}</pre> | no |
+| <a name="input_destination_port"></a> [destination\_port](#input\_destination\_port) | destination\_port\_range - Destination Port or Range. Integer or range between `0` and `65535` or `*` to match any.<br>destination\_port\_ranges - List of destination ports or port ranges. | <pre>object({<br>    range  = optional(string)<br>    ranges = optional(set(string))<br>  })</pre> | n/a | yes |
 | <a name="input_direction"></a> [direction](#input\_direction) | Specifies whether the rule will be evaluated on incoming or outgoing traffic. | `string` | n/a | yes |
 | <a name="input_name"></a> [name](#input\_name) | The name of the network security rule. | `string` | n/a | yes |
 | <a name="input_network_security_group_name"></a> [network\_security\_group\_name](#input\_network\_security\_group\_name) | The name of the network security group to which this rule will be attached. | `string` | n/a | yes |
 | <a name="input_priority"></a> [priority](#input\_priority) | Specifies the priority of the rule. | `number` | n/a | yes |
 | <a name="input_protocol"></a> [protocol](#input\_protocol) | The network protocol to which this rule applies. | `string` | n/a | yes |
 | <a name="input_resource_group_name"></a> [resource\_group\_name](#input\_resource\_group\_name) | The name of the resource group in which this resource will be provisioned. | `string` | n/a | yes |
-| <a name="input_source_address"></a> [source\_address](#input\_source\_address) | source\_address\_prefix - CIDR or source IP range or `*` to match any IP. Tags such as `VirtualNetwork`, `AzureLoadBalancer` and `Internet` can also be used.<br>source\_address\_prefixes - List of source address prefixes. Tags may not be used. | <pre>object({<br>    prefix   = optional(string)<br>    prefixes = optional(set(string))<br>  })</pre> | <pre>{<br>  "prefix": null,<br>  "prefixes": null<br>}</pre> | no |
+| <a name="input_source_address"></a> [source\_address](#input\_source\_address) | source\_address\_prefix - CIDR or source IP range or `*` to match any IP. Tags such as `VirtualNetwork`, `AzureLoadBalancer` and `Internet` can also be used.<br>source\_address\_prefixes - List of source address prefixes. Tags may not be used. | <pre>object({<br>    prefix   = optional(string)<br>    prefixes = optional(set(string))<br>  })</pre> | n/a | yes |
 | <a name="input_source_application_security_group_ids"></a> [source\_application\_security\_group\_ids](#input\_source\_application\_security\_group\_ids) | List of source Application Security Group ID's. | `set(string)` | `null` | no |
-| <a name="input_source_port"></a> [source\_port](#input\_source\_port) | source\_port\_range - Source Port or Range. Integer or range between `0` and `65535` or `*` to match any.<br>source\_port\_ranges - List of source ports or port ranges. | <pre>object({<br>    range  = optional(string)<br>    ranges = optional(set(string))<br>  })</pre> | <pre>{<br>  "range": "*",<br>  "ranges": null<br>}</pre> | no |
+| <a name="input_source_port"></a> [source\_port](#input\_source\_port) | source\_port\_range - Source Port or Range. Integer or range between `0` and `65535` or `*` to match any.<br>source\_port\_ranges - List of source ports or port ranges. | <pre>object({<br>    range  = optional(string)<br>    ranges = optional(set(string))<br>  })</pre> | n/a | yes |
 
 ## Outputs
 

modules/azure-network-security-rule/vars.tf

@@ -75,10 +75,6 @@ EOF
     range  = optional(string)
     ranges = optional(set(string))
   })
-  default = {
-    range  = "*"
-    ranges = null
-  }
   validation {
     condition     = !(var.source_port.range == null && var.source_port.ranges == null)
     error_message = "Either of \"source_port_range\" or \"source_port_ranges\" is required if the other is not specified."
@@ -98,10 +94,6 @@ EOF
     prefix   = optional(string)
     prefixes = optional(set(string))
   })
-  default = {
-    prefix   = null
-    prefixes = null
-  }
   validation {
     condition     = !(var.source_address.prefix == null && var.source_address.prefixes == null)
     error_message = "Either of \"source_address_prefix\" or \"source_address_prefixes\" is required if the other is not specified."
@@ -127,10 +119,6 @@ EOF
     range  = optional(string)
     ranges = optional(set(string))
   })
-  default = {
-    range  = null
-    ranges = null
-  }
   validation {
     condition     = !(var.destination_port.range == null && var.destination_port.ranges == null)
     error_message = "Either of \"destination_port_range\" or \"destination_port_ranges\" is required if the other is not specified."
@@ -150,10 +138,6 @@ EOF
     prefix   = optional(string)
     prefixes = optional(set(string))
   })
-  default = {
-    prefix   = null
-    prefixes = null
-  }
   validation {
     condition     = !(var.destination_address.prefix == null && var.destination_address.prefixes == null)
     error_message = "Either of \"destination_address_prefix\" or \"destination_address_prefixes\" is required if the other is not specified."