Refactor Hamming weight phasing to use QVR #1245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurudhp
force-pushed
the
2024/08/02-refactor-hw-phasing
branch
from
b88230d
to
5a66b97
Compare
anurudhp
force-pushed
the
2024/08/02-refactor-hw-phasing
branch
from
5a66b97
to
8543542
Compare
mpharrigan
reviewed
Aug 22, 2024
| def via_phase_gradient(cls, bitsize: int, exponent: float = 1, eps: SymbolicFloat = 1e-10): | ||
| r"""Factory method for `HammingWeightPhasing` using a phase gradient state. | ||
|
|
||
| In this variant of Hamming Weight Phasing, instead of directly synthesizing $O(\log_2 (\texttt{bitsize}))$ |
There was a problem hiding this comment.
I know you copied this, but can you hard-wrap the text to <100 columns. vim is gq ; pycharm is "edit -> fill paragraph"
mpharrigan
reviewed
Aug 22, 2024
| apply the phasing via addition. | ||
|
|
||
| References: | ||
| 1. [Compilation of Fault-Tolerant Quantum Heuristics for Combinatorial Optimization] |
There was a problem hiding this comment.
I know you copied this, but remove 1. from the list of references. We don't number them.
mpharrigan
reviewed
Aug 22, 2024
| phase_grad : Phase gradient THRU register of size `O(log2(1/eps))`, to be used to | ||
| apply the phasing via addition. | ||
|
|
||
| References: |
There was a problem hiding this comment.
consider moving the reference to the class docstring
mpharrigan
reviewed
Aug 22, 2024
| @@ -66,6 +69,7 @@ class HammingWeightPhasing(GateWithRegisters): | |||
|
|
|||
| Registers: | |||
| x: A `THRU` register of `bitsize` qubits. | |||
| extra_registers: Any additional registers used by the `QvrInterface` phase oracle. | |||
There was a problem hiding this comment.
document the new phase_oracle arg and reference the new factory method in the class docstring somewhere
|
@tanujkhattar original author of these bloqs: are you good with the merger? |
|
@tanujkhattar @anurudhp what's the status of this? |
|
This has deviated too much from main, closing it for now. We can make a new refactor PR if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1218