QCQMC notebooks #357
Merged
QCQMC notebooks #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@mpharrigan do I need to do anything more to ensure the docs render correctly / regenerate them? |
mpharrigan
reviewed
Jul 3, 2024
|
I think you need to list the new notebooks in |
|
I can also split this up if that's more digestible |
mpharrigan
reviewed
Jul 12, 2024
mpharrigan
reviewed
Jul 12, 2024
mpharrigan
reviewed
Jul 12, 2024
| ) | ||
|
|
||
| @classmethod | ||
| def build_hamiltonian_from_pyscf( |
There was a problem hiding this comment.
nit: can probably simplify the method name since you know it will be prepended with HamiltonianData.
There was a problem hiding this comment.
do you mean remove the "_from"?
mpharrigan
approved these changes
Jul 12, 2024
|
In terms of notebooks should these be cleared of output. Is the website updated automatically? |
dstrain115
reviewed
Jul 13, 2024
|
Yes, the website should execute the notebooks |
|
@dstrain115 is this approved? |
dstrain115
approved these changes
Jul 24, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 3 notebooks for the QCQMC paper:
Depends on #356