Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #15 to work with register class id #16

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix #15 to work with register class id #16

merged 1 commit into from
Nov 5, 2024

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Nov 5, 2024

No description provided.

@zhfeng zhfeng requested a review from a team as a code owner November 5, 2024 03:22
@zhfeng
Copy link
Contributor Author

zhfeng commented Nov 5, 2024

@chaokunyang can you take a look?

chaokunyang
chaokunyang approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit 4bcb233 into quarkiverse:main Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhfeng @chaokunyang