Merge pull request #62 from melloware/59

Fix #59: Added recordVideoDir option
quarkiverse · Jul 3, 2024 · ef0b0c0 · ef0b0c0
2 parents fa0cd40 + e18514c
commit ef0b0c0
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 5 deletions.
diff --git a/pom.xml b/pom.xml
@@ -23,12 +23,12 @@
     <tag>HEAD</tag>
   </scm>
   <properties>
-    <compiler-plugin.version>3.12.1</compiler-plugin.version>
+    <compiler-plugin.version>3.13.0</compiler-plugin.version>
     <maven.compiler.release>11</maven.compiler.release>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     <quarkus.version>3.3.1</quarkus.version>
-    <playright.version>1.41.2</playright.version>
+    <playright.version>1.44.0</playright.version>
   </properties>
   <dependencyManagement>
     <dependencies>
@@ -75,4 +75,4 @@
       </modules>
     </profile>
   </profiles>
-</project>
+</project>
diff --git a/testing/src/main/java/io/quarkiverse/playwright/QuarkusPlaywrightManager.java b/testing/src/main/java/io/quarkiverse/playwright/QuarkusPlaywrightManager.java
@@ -1,10 +1,13 @@
 package io.quarkiverse.playwright;
 
+import java.nio.file.Paths;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.microsoft.playwright.Browser;
 import com.microsoft.playwright.BrowserContext;
 import com.microsoft.playwright.BrowserType;
@@ -51,7 +54,12 @@ public Map<String, String> start() {
                 .setArgs(Arrays.asList(this.options.args()));
         this.playwrightBrowser = browser(playwright, this.options.browser()).launch(
                 launchOptions);
-        this.playwrightContext = playwrightBrowser.newContext();
+
+        final Browser.NewContextOptions contextOptions = new Browser.NewContextOptions();
+        if (StringUtils.isNotBlank(this.options.recordVideoDir())) {
+            contextOptions.setRecordVideoDir(Paths.get(this.options.recordVideoDir()));
+        }
+        this.playwrightContext = playwrightBrowser.newContext(contextOptions);
         return Collections.emptyMap();
     }
 
@@ -69,6 +77,10 @@ private static BrowserType browser(Playwright playwright, WithPlaywright.Browser
 
     @Override
     public void stop() {
+        if (this.playwrightContext != null) {
+            this.playwrightContext.close();
+            this.playwrightContext = null;
+        }
         if (playwright != null) {
             playwright.close();
             playwright = null;

diff --git a/testing/src/main/java/io/quarkiverse/playwright/WithPlaywright.java b/testing/src/main/java/io/quarkiverse/playwright/WithPlaywright.java
@@ -52,6 +52,11 @@
      */
     double slowMo() default 0;
 
+    /**
+     * Enables video recording for all pages into the specified directory. If not specified videos are not recorded.
+     */
+    String recordVideoDir() default "";
+
     /**
      * Args for use to launch the browser
      */
@@ -63,4 +68,4 @@ enum Browser {
         WEBKIT
     }
 
-}
+}