-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host migration pages on main website instead of/as well as wiki #2108
Draft
holly-cummins
wants to merge
10
commits into
quarkusio:main
Choose a base branch
from
holly-cummins:migration-content
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 PR Preview 6cc52cc has been successfully built and deployed to https://quarkus-site-pr-2108-preview.surge.sh
|
holly-cummins
force-pushed
the
migration-content
branch
from
September 2, 2024 21:21
caed00d
to
a65f370
Compare
holly-cummins
force-pushed
the
migration-content
branch
from
September 2, 2024 21:32
a65f370
to
b140bb6
Compare
holly-cummins
force-pushed
the
migration-content
branch
from
September 2, 2024 21:49
b140bb6
to
6eeae61
Compare
holly-cummins
force-pushed
the
migration-content
branch
from
September 3, 2024 14:23
90fb697
to
bdfa537
Compare
holly-cummins
force-pushed
the
migration-content
branch
from
September 3, 2024 14:53
bdfa537
to
9323742
Compare
holly-cummins
changed the title
Draft: Proof of concept for migration pages
Host migration pages on main website instead of wiki
Sep 3, 2024
holly-cummins
changed the title
Host migration pages on main website instead of wiki
Host migration pages on main website instead of/as well as wiki
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2105.
Example output:
This is now ready to merge, except for a decision on whether we want to sync from the wiki content or clone-and-delete it. (See discussion in #2105.) In either case, the structure, filenames, and content of the source migration guides can stay the same as they currently are.
For now I've done a clone, which also simulates the effect of a sync from the wiki. Some frontmatter additions and one filename change need to be replicated back to the wiki if we keep the source of truth to be those files.
Once merged, 'edit this page' links should work.
Index page
On the old wiki, we hand-maintain an index page. I have replaced that with an auto-generated one, which should be easier going forward. It does require some metadata in the frontmatter. For example,
(For non-LTS releases, there's no need to add the LTS field.)