Merge pull request #7111 from quarto-dev/bugfix/6853

revealjs: wrap callout in div if attr is nontrivial

news/changelog-1.4.md

@@ -47,6 +47,7 @@
 - ([#5783](https://github.com/quarto-dev/quarto-cli/issues/5783)): Ensure fenced code blocks work with line numbers.
 - ([#6120](https://github.com/quarto-dev/quarto-cli/issues/6120)): `pdf-max-pages-per-slide` is now correctly setting [`pdfMaxPagesPerSlide` config](https://revealjs.com/pdf-export/#page-size) for RevealJS.
 - ([#6827](https://github.com/quarto-dev/quarto-cli/issues/6120)): Correctly layout callout in revealjs slides when changing appearance.
+- ([#6853](https://github.com/quarto-dev/quarto-cli/issues/6853), [#5208](https://github.com/quarto-dev/quarto-cli/issues/5208)): Wrap callout in div when attr is non-empty.
 - ([#7042](https://github.com/quarto-dev/quarto-cli/issues/7042)): Line highligthting now works correctly with code annotation.
 - ([#7104](https://github.com/quarto-dev/quarto-cli/issues/7104)): Line highlighting progressive reveal now correctly has code annotation anchor on the right.
 

src/resources/filters/customnodes/callout.lua

@@ -381,7 +381,15 @@ function epubCallout(node)
   end
   attributes:insert("callout-style-" .. calloutAppearance)
 
-  return pandoc.Div({calloutBody}, pandoc.Attr(node.id or "", attributes))
+  local result = pandoc.Div({calloutBody}, pandoc.Attr(node.id or "", attributes))
+  -- in revealjs or epub, if the leftover attr is non-trivial, 
+  -- then we need to wrap the callout in a div (#5208, #6853)
+  if node.attr.identifier ~= "" or #node.attr.classes > 0 or #node.attr.attributes > 0 then
+    return pandoc.Div({ result }, node.attr)
+  else
+    return result
+  end
+
 end
 
 function simpleCallout(node) 

tests/docs/smoke-all/2023/10/02/6853.qmd

@@ -0,0 +1,19 @@
+---
+format: revealjs
+title: test
+_quarto:
+  tests:
+    revealjs:
+      ensureHtmlElements:
+        - ["div.fragment", "div#hello-world"]
+        - []
+---
+
+
+::: {#hello-world .callout-note .fragment}
+
+## A title
+
+Some content
+
+:::