Typst brand yaml: typography bells and whistles #10974
Conversation
gordonwoodhull
force-pushed
the
feature/typst-brand-yaml-bells-and-whistles
branch
from
eeafabf to
094ebe2
Compare
weight style size decoration color background-color line-height
there are no abstractions here each element has different properties supported
gordonwoodhull
force-pushed
the
feature/typst-brand-yaml-bells-and-whistles
branch
from
094ebe2 to
6cb26c3
Compare
gordonwoodhull
force-pushed
the
feature/typst-brand-yaml-bells-and-whistles
branch
from
5a7055f to
26b8a1e
Compare
|
Hmm, perhaps I should not use It is helpful for testing that the font caching pipeline is working, because I can #set text(fallback: false)and Typst won’t output text in fonts it doesn’t have. But So I’ve got one falling test which I give up on for today. But otherwise this is ready. |
rename typst_css_to_props typst_css_property_processing
gordonwoodhull
force-pushed
the
feature/typst-brand-yaml-bells-and-whistles
branch
from
cea828e to
e071aa8
Compare
basis case for translating base.size: 1rem to avoid infinite recursion expose parse_length and use for base.size
broaden test for inconsident spaces in pdftotext pdftotext provides inherently inconsistent output with spaces and even ordering varying by platform it should probably not be used with such long strings (and this isn't necessary because the properties are tested in ensureTypstFileRegexMatches)
gordonwoodhull
force-pushed
the
feature/typst-brand-yaml-bells-and-whistles
branch
from
e071aa8 to
29aca72
Compare
There was a problem hiding this comment.
@gordonwoodhull do we want to keep the PDF committed ?
Is this to have an example of default template ?
Just wondering, it case it was for testing initially
There was a problem hiding this comment.
Thanks @cderv!
Nope, it looks like this artifact is generated when the .typ is edited in vscode. (Seems to happen with any valid .typ file.) There is no reason to compile a template on its own, never mind check it in.
I've removed it.
This is in good shape and has basic test coverage for all supported feature-element combinations.
Also includes support for subtitles in typst, taking @mcanouil's contribution to the Pandoc template from upstream #9638, and styling it as a heading.
Leaving this as a draft for now because although I'd be happy merging this in its current state, there are a few last touches to make:
brand.typographyshould allow use of named colors frombrand.colorforcolor,background-colorremcorrectly whenbrand.typography.base.sizeis specified. Current blind change toemwill be the fallback with a warning whenbase.sizeis unknownpaddingandwidthfor logo - currently one must use Typst-compatible units.