-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typst CSS #9619
Typst CSS #9619
Conversation
Ah yes, will need Pandoc 3.1.14 to run the tests in CI |
gt and Great Tables get some nice effects out of putting borders on spans. See Time and Measurement in this gt screenshot: It is also possible to put borders on a Typst Naive Typst gt is using
|
8f9ec37
to
a02e29b
Compare
Pandoc 3.2 doesn't seem to cause any failures. Rough edges we should probably handle before merging:
|
I wonder if this is because we're hammering placeholder.co and we should use some other solution instead. |
Kind of weird, maybe coincidental.
|
Okay, this is only blocked by mediabag issues on both platforms. It's weird that it's always the same file, and I can repro the error locally, but I am giving up on it for the moment. I have some hardening to do on Typst CSS inputs and need to test malformed input, which I can do before or after merge. |
Can you just clarify which |
|
Ok - I think that failure is placeholder.co etc no longer being reliable. |
9612dd6
to
8734f9f
Compare
8734f9f
to
41f2194
Compare
There are very occasional mermaid timeouts, but everything else is running well. Ok to merge? |
Let's do it! |
This is about ready to merge, once there is a new Pandoc release.
With full CSS rgb and named color support and the border shorthands, the Lua script to do CSS->Typst translation is about 4x as long as it was (now ~900 lines).
Posting the PR for review tomorrow as well as to see how the tests do.
Will follow up with open questions & areas to review, or bring those tomorrow.
This subsumes #9500.