-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: problem with multibyte characters in julia engine #9740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to ensure consistent formatting, but the content looks good. Thank you!
@MHellmund We also need a contributor agreement from you. |
This looks good! I'll await confirmation on the contributor agreement and we'll merge. Thank you for the good fix! |
I just sent the contributor agreement to jj@rstudio.com |
Please don't merge yet, I think I found a problem. |
Got it. Thanks for following up, and good thing I was out on vacation most of last week! :) |
It's amazing how many tests a wrong code can pass before you run into heisenbugs with a larger document. |
Thanks, @MHellmund! If you have tests you can share publicly, we'd love to run them in our suite going forward. |
There is the test enclosed to the original bug report PumasAI/QuartoNotebookRunner.jl#130 . |
Description
This concerns the new julia engine and solves issue PumasAI/QuartoNotebookRunner.jl#130
Checklist
I have (if applicable):